client: drop unused /config fallback#5954
Conversation
A comment claimed zedclient would fall back to the legacy /config endpoint when the /uuid endpoint fails. The fallback was never wired up — the /uuid path is the only one taken at runtime. Remove the unreachable helpers and the comment. No behavior change. Signed-off-by: eriknordmark <erik@zededa.com> Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #5954 +/- ##
==========================================
+ Coverage 20.50% 20.92% +0.42%
==========================================
Files 487 497 +10
Lines 90131 91771 +1640
==========================================
+ Hits 18482 19204 +722
- Misses 70095 70829 +734
- Partials 1554 1738 +184 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Claude finished @rene's task in 1m 15s —— View job Code Review
No issues found. The removal is clean: all three deleted functions ( |
rene
left a comment
There was a problem hiding this comment.
LGTM - asked claude for testing the workflow....
Description
Found some dead comment and dead code from a long time ago when we introduced the /uuid API endoint in the controllers.
zedclient's
doGetUUIDcarried a comment promising a fall-back to thelegacy
/configendpoint when/uuidfails. The fallback was neverwired up — only the
/uuidpath is reachable. This PR removes theunreachable code and the misleading comment. No behavior change.
How to test and validate this PR
Onboard a device against any controller and confirm the device UUID is
fetched and written as before. Existing onboarding e2e in Eden covers
this path; no new test added in this PR.
Changelog notes
No user-facing changes.
PR Backports
Checklist