Skip to content

client: drop unused /config fallback#5954

Merged
eriknordmark merged 1 commit into
lf-edge:masterfrom
eriknordmark:client-remove-dead-config-fallback
May 20, 2026
Merged

client: drop unused /config fallback#5954
eriknordmark merged 1 commit into
lf-edge:masterfrom
eriknordmark:client-remove-dead-config-fallback

Conversation

@eriknordmark
Copy link
Copy Markdown
Contributor

@eriknordmark eriknordmark commented May 13, 2026

Description

Found some dead comment and dead code from a long time ago when we introduced the /uuid API endoint in the controllers.

zedclient's doGetUUID carried a comment promising a fall-back to the
legacy /config endpoint when /uuid fails. The fallback was never
wired up — only the /uuid path is reachable. This PR removes the
unreachable code and the misleading comment. No behavior change.

How to test and validate this PR

Onboard a device against any controller and confirm the device UUID is
fetched and written as before. Existing onboarding e2e in Eden covers
this path; no new test added in this PR.

Changelog notes

No user-facing changes.

PR Backports

  • 16.0-stable: No.
  • 14.5-stable: No.
  • 13.4-stable: No.

Checklist

  • I've provided a proper description
  • I've written the test verification instructions

A comment claimed zedclient would fall back to the legacy /config
endpoint when the /uuid endpoint fails. The fallback was never wired
up — the /uuid path is the only one taken at runtime. Remove the
unreachable helpers and the comment.

No behavior change.

Signed-off-by: eriknordmark <erik@zededa.com>
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@codecov
Copy link
Copy Markdown

codecov Bot commented May 13, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 20.92%. Comparing base (d093be1) to head (7c9c3f3).
⚠️ Report is 6 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5954      +/-   ##
==========================================
+ Coverage   20.50%   20.92%   +0.42%     
==========================================
  Files         487      497      +10     
  Lines       90131    91771    +1640     
==========================================
+ Hits        18482    19204     +722     
- Misses      70095    70829     +734     
- Partials     1554     1738     +184     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@eriknordmark eriknordmark marked this pull request as ready for review May 15, 2026 07:06
@eriknordmark eriknordmark requested review from deitch and rene May 15, 2026 07:07
@rene
Copy link
Copy Markdown
Contributor

rene commented May 20, 2026

@claude

@claude
Copy link
Copy Markdown

claude Bot commented May 20, 2026

Claude finished @rene's task in 1m 15s —— View job


Code Review

  • Read PR diff and changed files
  • Review code changes
  • Post inline comments

No issues found. The removal is clean: all three deleted functions (parseConfig, validateConfigMessage, readConfigResponseProtoMessage), the prevConfigHash global, and the passthrough doGetUUID wrapper have zero remaining callers. The dead import removals (fmt, mime, zconfig) and the explicit uuid alias are correct. The improved docstring on parseUUIDResponse is accurate.

Copy link
Copy Markdown
Contributor

@rene rene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - asked claude for testing the workflow....

@eriknordmark eriknordmark merged commit aa6798d into lf-edge:master May 20, 2026
46 of 49 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants