Skip to content

Fix buffer overrun in event_payload_pool_test.c#354

Merged
tanneberger merged 1 commit into
lf-lang:mainfrom
NicoBiernat:fix-event-payload-pool-test-buffer-overrun
May 20, 2026
Merged

Fix buffer overrun in event_payload_pool_test.c#354
tanneberger merged 1 commit into
lf-lang:mainfrom
NicoBiernat:fix-event-payload-pool-test-buffer-overrun

Conversation

@NicoBiernat
Copy link
Copy Markdown
Collaborator

In test: test_allocate_reserved (buffer size too small)

Fixes issue #353

Copy link
Copy Markdown
Collaborator

@erlingrj erlingrj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@erlingrj
Copy link
Copy Markdown
Collaborator

erlingrj commented May 5, 2026

Some of the CI errors are expected since @NicoBiernat is not a maintainer and thus we get some permission issues wrt generating comments on the PR with coverage etc. We should look into that.

But I am seeing two failures when running LFC on Federated Templates and PATMOS. Do you recognize this @tanneberger ?

lfc: fatal error: Error running generator
java.util.NoSuchElementException: List is empty.
	at kotlin.collections.CollectionsKt___CollectionsKt.first(_Collections.kt:214)
	at org.lflang.generator.uc.UcGeneratorFederated.doGenerate(UcGeneratorFederated.kt:133)
	at org.lflang.generator.LFGenerator.doGenerate(LFGenerator.java:65)
	at org.eclipse.xtext.generator.GeneratorDelegate.doGenerate(GeneratorDelegate.java:44)
	at org.eclipse.xtext.generator.GeneratorDelegate.generate(GeneratorDelegate.java:35)
	at org.lflang.cli.Lfc.invokeGenerator(Lfc.java:234)
	at org.lflang.cli.Lfc.doRun(Lfc.java:193)
	at org.lflang.cli.CliBase.run(CliBase.java:124)
	at picocli.CommandLine.executeUserObject(CommandLine.java:2026)
	at picocli.CommandLine.access$1500(CommandLine.java:148)
	at picocli.CommandLine$RunLast.executeUserObjectOfLastSubcommandWithSameParent(CommandLine.java:2461)
	at picocli.CommandLine$RunLast.handle(CommandLine.java:2453)
	at picocli.CommandLine$RunLast.handle(CommandLine.java:2415)
	at picocli.CommandLine$AbstractParseResultHandler.execute(CommandLine.java:2273)
	at picocli.CommandLine$RunLast.execute(CommandLine.java:2417)
	at picocli.CommandLine.execute(CommandLine.java:2170)
	at org.lflang.cli.CliBase.doExecute(CliBase.java:115)
	at org.lflang.cli.CliBase.cliMain(CliBase.java:107)
	at org.lflang.cli.Lfc.main(Lfc.java:181)
	at org.lflang.cli.Lfc.main(Lfc.java:171

@tanneberger
Copy link
Copy Markdown
Member

@erlingrj yeah the CI errors are not caused by this PR, they come from something previously merged, but I wasn't yet able to fully fix the issue.

@NicoBiernat NicoBiernat force-pushed the fix-event-payload-pool-test-buffer-overrun branch from 967f292 to 6b8cf7e Compare May 18, 2026 19:06
@tanneberger tanneberger merged commit 3eb7225 into lf-lang:main May 20, 2026
12 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants