Fix too many commas in ctor definition for custom network channel#367
Open
NicoBiernat wants to merge 1 commit into
Open
Fix too many commas in ctor definition for custom network channel#367NicoBiernat wants to merge 1 commit into
NicoBiernat wants to merge 1 commit into
Conversation
tanneberger
force-pushed
the
main
branch
2 times, most recently
from
July 4, 2026 21:12
ca0ae03 to
bcbf975
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The code generator adds one more comma than needed for the custom network channel constructor causing a C syntax error.
If the custom channel takes no arguments except the channel pointer, it would generate something like:
MyCustomNetworkChannel_ctor(&self->channel,);With an argument it would generate:
MyCustomNetworkChannel_ctor(&self->channel,,my_argument);I removed the extra comma in the generator function.