Fix warnings

Author: lfir

src/test/java/cf/maybelambda/httpvalidator/springboot/itest/AppConfigurationControllerIntegrationTests.java

@@ -56,7 +56,7 @@
 @ActiveProfiles("test")
 @SpringBootTest
 public class AppConfigurationControllerIntegrationTests {
-    public static String UPD_DATAFILE_ERRORS_DESCR = INVALID_DATA_FILE_ERROR_MSG + " or " + UPD_DATA_FILE_ERROR_MSG;
+    public static final String UPD_DATAFILE_ERRORS_DESCR = INVALID_DATA_FILE_ERROR_MSG + " or " + UPD_DATA_FILE_ERROR_MSG;
     private String testsToken;
     private MockMvc mockMvc;
 
@@ -138,12 +138,12 @@ public void canUpdateDataFileWithValidXML() throws Exception {
             .andDo(document("{method-name}", REQUEST_HEADERS_SNIPPET));
 
         assertThat(this.dao.isDataFileStatusOk()).isTrue();
-        assertThat(this.dao.getAll().get(0)).isEqualTo(task);
+        assertThat(this.dao.getAll().getFirst()).isEqualTo(task);
     }
 
     @Test
     public void error400WhenUpdateDataFileRequestWithInvalidXML() throws Exception {
-        ValidationTask task = this.dao.getAll().get(0);
+        ValidationTask task = this.dao.getAll().getFirst();
 
         String xmlContent =   "<?xml version=\"1.0\" encoding=\"UTF-8\"?>"
                             + "<validations>"
@@ -175,6 +175,6 @@ public void error400WhenUpdateDataFileRequestWithInvalidXML() throws Exception {
             );
 
         // Verify the original file contents have not been modified
-        assertThat(this.dao.getAll().get(0)).isEqualTo(task);
+        assertThat(this.dao.getAll().getFirst()).isEqualTo(task);
     }
 }

src/test/java/cf/maybelambda/httpvalidator/springboot/itest/AppInfoControllerIntegrationTests.java

@@ -51,10 +51,14 @@ public class AppInfoControllerIntegrationTests {
     );
     public static final String START_TIME_DESCR = "The start time of the application in a formatted string";
     public static final String START_TIME_LR_DESCR = "The start time of the last run in a formatted string";
-    public static final String DATAFILE_STATUS_DESCR = "`OK`: Data file status is okay, i.e. it "
-        + "exists and is readable\n\n`ERROR`: Data file status is not okay";
-    public static final String CONFIG_STATUS_DESCR = "`OK`: Both mail and validation configurations are okay (run "
-        + "schedule, credentials, from and to addresses)\n\n`ERROR`: Either mail or validation configuration is not okay";
+    public static final String DATAFILE_STATUS_DESCR = """
+            `OK`: Data file status is okay, i.e. it exists and is readable
+            
+            `ERROR`: Data file status is not okay""";
+    public static final String CONFIG_STATUS_DESCR = """
+            `OK`: Both mail and validation configurations are okay (run schedule, credentials, from and to addresses)
+            
+            `ERROR`: Either mail or validation configuration is not okay""";
     public static final String TIME_ELAPSED_DESCR = "Duration of the last run";
     public static final String TASKS_TOTAL_DESCR = "The total number of tasks to be processed in the last run";
     public static final String TASKS_OK_DESCR = "The number of tasks with expected results";

src/test/java/cf/maybelambda/httpvalidator/springboot/persistence/XMLValidationTaskDaoTests.java

@@ -127,12 +127,12 @@ void taskDataIsReadWhenWellFormedXMLParsedWithoutErrors() throws Exception {
 
         List<ValidationTask> ans = this.taskDao.getAll();
 
-        assertEquals(GET, ans.get(0).reqMethod());
-        assertEquals(this.url.getTextContent(), ans.get(0).reqURL());
-        assertEquals(this.header.getTextContent(), ans.get(0).reqHeaders().get(0));
-        assertEquals(this.mapper.readTree(this.reqbody.getTextContent()), ans.get(0).reqBody());
-        assertEquals(Integer.parseInt(this.resBodyAttrs.getNamedItem(RES_SC_ATTR).getTextContent()), ans.get(0).validStatusCode());
-        assertEquals(this.response.getTextContent(), ans.get(0).validBody());
+        assertEquals(GET, ans.getFirst().reqMethod());
+        assertEquals(this.url.getTextContent(), ans.getFirst().reqURL());
+        assertEquals(this.header.getTextContent(), ans.getFirst().reqHeaders().getFirst());
+        assertEquals(this.mapper.readTree(this.reqbody.getTextContent()), ans.getFirst().reqBody());
+        assertEquals(Integer.parseInt(this.resBodyAttrs.getNamedItem(RES_SC_ATTR).getTextContent()), ans.getFirst().validStatusCode());
+        assertEquals(this.response.getTextContent(), ans.getFirst().validBody());
     }
 
     @Test
@@ -147,8 +147,8 @@ void xmlAttributesThatCanBeEmptyInDatafileAreParsedOk() throws Exception {
 
         List<ValidationTask> ans = this.taskDao.getAll();
 
-        assertThat(ans.get(0).reqHeaders().isEmpty()).isTrue();
-        assertEquals("", ans.get(0).validBody());
+        assertThat(ans.getFirst().reqHeaders().isEmpty()).isTrue();
+        assertEquals("", ans.getFirst().validBody());
     }
 
     @Test
@@ -160,7 +160,7 @@ void whenGetAllThrowsSAXExceptionThenErrorIsLogged() throws Exception {
     }
 
     @Test
-    void whenJacksonThrowsJSONExceptionInGetAllThenErrorIsLogged() throws Exception {
+    void whenJacksonThrowsJSONExceptionInGetAllThenErrorIsLogged() {
         // Number of <validation> elements
         given(this.nodes.getLength()).willReturn(1);
         // 2 child nodes of <validation>: <url> and <reqbody>

src/test/java/cf/maybelambda/httpvalidator/springboot/service/ValidationServiceTests.java

@@ -117,7 +117,7 @@ void whenExceptionOccursDuringExecValidationsRequestNotificationIsSent() throws
 
         this.vs.execValidations();
 
-        assertEquals(1, this.tasks.get(0).reqHeaders().size());
+        assertEquals(1, this.tasks.getFirst().reqHeaders().size());
         verify(this.ns).sendVTaskErrorsNotification(anyList());
     }
 
@@ -134,7 +134,7 @@ void execValidationsLogsValidTaskResult() throws Exception {
 
         this.vs.execValidations();
 
-        assertThat(this.dao.getAll().get(0).reqHeaders().isEmpty()).isTrue();
+        assertThat(this.dao.getAll().getFirst().reqHeaders().isEmpty()).isTrue();
         verify(this.logger).info(anyString());
     }