fix: inject notebook name and description into chat system prompt#719
Merged
Conversation
The chat system prompt template had a conditional block for notebook metadata but the /chat/execute endpoint never populated it. Fetch the notebook linked to the session via the refers_to relationship and pass it to the graph state so the LLM receives the notebook's name and description as project context. Closes #685
Contributor
There was a problem hiding this comment.
1 issue found across 2 files
Confidence score: 3/5
- There is a concrete user-impacting risk in
api/routers/chat.py: when notebook lookup raisesNotFoundError, it is mapped to "Session not found," which can fail valid sessions if the linked notebook is missing. - I’m scoring this as moderate merge risk because the issue is medium severity (6/10) with high confidence (8/10) and affects request error handling behavior.
- Pay close attention to
api/routers/chat.py- exception mapping may return the wrong failure mode and block otherwise valid session flows.
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="api/routers/chat.py">
<violation number="1" location="api/routers/chat.py:352">
P2: Notebook lookup can raise `NotFoundError` that is incorrectly converted to "Session not found", causing valid sessions to fail when linked notebook is missing.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
| ) | ||
| notebook = None | ||
| if notebook_query: | ||
| notebook = await Notebook.get(notebook_query[0]["out"]) |
Contributor
There was a problem hiding this comment.
P2: Notebook lookup can raise NotFoundError that is incorrectly converted to "Session not found", causing valid sessions to fail when linked notebook is missing.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At api/routers/chat.py, line 352:
<comment>Notebook lookup can raise `NotFoundError` that is incorrectly converted to "Session not found", causing valid sessions to fail when linked notebook is missing.</comment>
<file context>
@@ -342,6 +342,15 @@ async def execute_chat(request: ExecuteChatRequest):
+ )
+ notebook = None
+ if notebook_query:
+ notebook = await Notebook.get(notebook_query[0]["out"])
+
# Determine model override (per-request override takes precedence over session-level)
</file context>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
refers_torelationship in the/chat/executeendpointnotebook.nameandnotebook.descriptioninstead of the raw objectCloses #685
Test plan