Skip to content

Fix OpenAI model discovery base URL override#784

Open
Genmin wants to merge 1 commit into
lfnovo:mainfrom
Genmin:fix/openai-discovery-base-url
Open

Fix OpenAI model discovery base URL override#784
Genmin wants to merge 1 commit into
lfnovo:mainfrom
Genmin:fix/openai-discovery-base-url

Conversation

@Genmin
Copy link
Copy Markdown

@Genmin Genmin commented May 1, 2026

Summary

  • use the configured OpenAI base_url for model discovery instead of always calling https://api.openai.com/v1/models
  • avoid appending /models twice when an OpenAI-compatible endpoint already includes that path
  • add regression coverage for OpenAI and OpenAI-compatible discovery URLs

Validation

  • uv run pytest tests/test_credentials_api.py -q
  • uv run ruff check api/credentials_service.py tests/test_credentials_api.py

Fixes #676

Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: [OpenAI] Discover Models ignores Base URL override

1 participant