Support multiple source elements#262
Open
mysticflute wants to merge 4 commits into
Open
Conversation
mysticflute
changed the title
lhz516
reviewed
Sep 8, 2025
Comment on lines
+59
to
+71
| <AudioPlayer | ||
| srcKey={track.src} | ||
| onEnded={this.handleClickNext} | ||
| autoPlayAfterSrcChange={true} | ||
| showSkipControls={true} | ||
| showJumpControls={false} | ||
| onClickPrevious={this.handleClickPrevious} | ||
| onClickNext={this.handleClickNext} | ||
| > | ||
| <source src={track.src} type={track.type} /> | ||
| {track.additionalSrcs && | ||
| track.additionalSrcs.map(({ src, type }) => <source key={src} src={src} type={type} />)} | ||
| </AudioPlayer> |
Owner
There was a problem hiding this comment.
I feel using srcKey is confusing since in a native audio tag, it either has src attribute or source children. could you try an approach that only uses sources without adding a new prop?
mysticflute
commented
Sep 19, 2025
|
|
||
| if (prevProps.src !== src) { | ||
| isAudioSrcChanged = true | ||
| } else if (children && Children.count(children) > 0) { |
Author
There was a problem hiding this comment.
probably not the best idea to check the children like this, but it does add to the convenience for autoplay.
alternatively i could remove it, leaving the dev to implement autoplay when using <source> elements, perhaps an approach with useEffect with the playlist index changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #249.
This adds support for multiple
<source>elements as an alternative to a singlesrcattribute. Example:I'm using the
currentSrcattribute to achieve this, based on this info:https://developer.mozilla.org/en-US/docs/Web/API/HTMLMediaElement/currentSrc