Skip to content

Add preparation flag related to sub id to name map#4485

Open
lindsayad wants to merge 3 commits into
libMesh:develfrom
lindsayad:sub-map-sync
Open

Add preparation flag related to sub id to name map#4485
lindsayad wants to merge 3 commits into
libMesh:develfrom
lindsayad:sub-map-sync

Conversation

@lindsayad

Copy link
Copy Markdown
Member

And make sure we do sync the map when we're completing preparation

@moosebuild

moosebuild commented Jun 17, 2026

Copy link
Copy Markdown

Job Coverage, step Generate coverage on 2be9790 wanted to post the following:

Coverage

142ae1 #4485 2be979
Total Total +/- New
Rate 65.61% 65.61% +0.00% 100.00%
Hits 78653 78665 +12 17
Misses 41232 41231 -1 0

Diff coverage report

Full coverage report

This comment will be updated on new commits.

@roystgnr

roystgnr commented Jul 6, 2026

Copy link
Copy Markdown
Member

At first glance it looks like we just need to fix up downstream use cases before we can rebase this and retry CI ...

But at second glance, it looks like at least some of those failures downstream are because we're e.g. asserting _mesh->is_prepared() where we should only be asserting _mesh->_preparation.has_boundary_id_sets? We might be able to fix that here; I could push a commit to try, if my comment here isn't clear enough.

@roystgnr

roystgnr commented Jul 7, 2026

Copy link
Copy Markdown
Member

Huh. Now I'm seeing is_prepared() assertions failing in DofMap, and I don't actually want to weaken those. We really shouldn't be getting to DoF numbering or renumbering without a prepare_for_use() (or ideally complete_preparation()) first, and I'm not sure how we are.

lindsayad added a commit to lindsayad/libmesh that referenced this pull request Jul 7, 2026
@lindsayad

lindsayad commented Jul 7, 2026

Copy link
Copy Markdown
Member Author

Those failures will be fixed by idaholab/moose#33276, so we can wait for that to make it to MOOSE master and then invalidate here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants