Cleanup output system for writing truly constant monomial data#4491
Open
lindsayad wants to merge 3 commits into
Open
Cleanup output system for writing truly constant monomial data#4491lindsayad wants to merge 3 commits into
lindsayad wants to merge 3 commits into
Conversation
There's a decent amount of `operator==` comparisons with `FEType`, and this would lead to rejection of the new `p_refinement == false` option for `CONSTANT MONOMIAL` finite element types when determining elemental data for output. This changeset consolidates some code into `EquationSystems` for use in both exodus and nemesis. We also consolidate our definition of elemental data to always include scalar field and vector field monomials. Consistent with previous library behavior we treat `CONSTANT MONOMIAL` with `p_refinement == true` as elemental data even though it's possible that if the mesh has been p-refined this conceptually may not be the case. Co-authored-by: Codex <codex@openai.com>
Co-authored-by: Codex <codex@openai.com>
Co-authored-by: Codex <codex@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There's a decent amount of
operator==comparisons withFEType, and this would lead to rejection of the newp_refinement == falseoption forCONSTANT MONOMIALfinite element types when determining elemental data for output. This changeset consolidates some code intoEquationSystemsfor use in both exodus and nemesis. We also consolidate our definition of elemental data to always include scalar field and vector field monomials. Consistent with previous library behavior we treatCONSTANT MONOMIALwithp_refinement == trueas elemental data even though it's possible that if the mesh has been p-refined this conceptually may not be the case.