Add doi pattern#131
Conversation
|
Draft PR for help from David |
| letter-spacing: $font-letterspacing-label; | ||
| text-align: center; // stylelint-disable-line csstools/use-logical | ||
|
|
||
| @include mq($from: wide) { |
There was a problem hiding this comment.
Lines 14 through 24 can be simplified, for example:
- only need one media query
- the feature query is not needed here as
align-selfwill be ignored by non-supporting browsers. As long as anydisplay: flexis wrapped within a feature query, the other flex-specific properties don't need to be (but may be).
| @include block-spacing($end: $baselinegrid-space-medium); | ||
| @include border(block-end); | ||
| @include padding($baselinegrid-space-extra_small, block); | ||
| @include text-align(center); |
There was a problem hiding this comment.
Will need to be changed when other things are put into contextual-data, but for now as it only contains one thing (the doi), simple text-alignment is enough here.
| { | ||
| template: 'organisms-content-header', | ||
| arguments: contentHeader, | ||
| arguments: contentHeader|merge({ compact: true }), |
There was a problem hiding this comment.
This is a shame (especially as it has to be implemented by the user). Makes me think we do need to consider it part of the content header.
There was a problem hiding this comment.
Looking at eLife's version, the Content Header doesn't have any block-end margin. That could work here too, but means that we'd need to add some block-start spacing elsewhere...
There was a problem hiding this comment.
I agree this could be in the content header as well. It would simplify things.
| @import "../../settings/baselinegrid"; | ||
| @import "../../settings/color"; | ||
|
|
||
| .contextual-data { |
There was a problem hiding this comment.
Never been a fan of the name.
There was a problem hiding this comment.
We need some suggestions then. I cannot think of anything off the top of my head at the moment apart from info-data.
| } | ||
|
|
||
| .reference__doi { | ||
| @include doi(); |
There was a problem hiding this comment.
When this is removed, the letter-spacing: $font-letterspacing-label still needs adding (to match eLife). Which shows the name is wrong (since this isn't a label).
Makes me wonder... are we always applying this to small (-3, maybe more) text?
There was a problem hiding this comment.
This is the only bit I have not done as do not fully understand.
There was a problem hiding this comment.
This is an unrelated bug fix anyway, will wait for @davidcmoulton's return.
3 participants
No description provided.