Merge pull request #3 from libi/fix/profile-test-cases

fix test cause

Author: libi

tests/diff_trace_state_test.go

@@ -565,7 +565,10 @@ func TestState_Import_NonexistentFile(t *testing.T) {
 // ---------- Profile Option ----------
 
 func TestProfile_Option(t *testing.T) {
-	tmpDir := t.TempDir()
+	tmpDir, err := os.MkdirTemp("", "ko-browser-profile-*")
+	if err != nil {
+		t.Fatalf("MkdirTemp: %v", err)
+	}
 	profileDir := filepath.Join(tmpDir, "test-profile")
 
 	b, err := browser.New(browser.Options{
@@ -576,16 +579,27 @@ func TestProfile_Option(t *testing.T) {
 	if err != nil {
 		t.Fatalf("browser.New with profile: %v", err)
 	}
+	closed := false
+	closeBrowser := func() {
+		if !closed {
+			b.Close()
+			closed = true
+		}
+	}
+	t.Cleanup(func() {
+		closeBrowser()
+		removeDirEventually(t, tmpDir)
+	})
 
 	// Navigate to a page
 	if err := b.Open(testdataURL("phase7_test.html")); err != nil {
-		b.Close()
+		closeBrowser()
 		t.Fatalf("Open: %v", err)
 	}
 
 	// Set some data in localStorage
 	if _, err := b.Eval(`localStorage.setItem("profile_test", "yes")`); err != nil {
-		b.Close()
+		closeBrowser()
 		t.Fatalf("set localStorage: %v", err)
 	}
 
@@ -595,7 +609,7 @@ func TestProfile_Option(t *testing.T) {
 	}
 
 	t.Logf("Profile directory created at: %s", profileDir)
-	b.Close()
+	closeBrowser()
 }
 
 // ---------- Config File ----------

tests/helpers_test.go

@@ -138,6 +138,30 @@ func must(t *testing.T, err error) {
 	}
 }
 
+func removeDirEventually(t *testing.T, path string) {
+	t.Helper()
+	if path == "" {
+		return
+	}
+
+	deadline := time.Now().Add(5 * time.Second)
+	var lastErr error
+	for time.Now().Before(deadline) {
+		lastErr = os.RemoveAll(path)
+		if lastErr == nil {
+			if _, statErr := os.Stat(path); os.IsNotExist(statErr) {
+				return
+			}
+		}
+		time.Sleep(100 * time.Millisecond)
+	}
+
+	if lastErr == nil {
+		lastErr = fmt.Errorf("directory still exists after cleanup retries")
+	}
+	t.Fatalf("cleanup dir %s: %v", path, lastErr)
+}
+
 // evalVoid evaluates a JS expression and discards the result. Fatals on error.
 func evalVoid(t *testing.T, b *browser.Browser, expression string) {
 	t.Helper()