Skip to content

Commit 8e2ffaf

Browse files
authored
PWX-29253: Adding support for gke-gcloud-auth-plugin (#1312)
Signed-off-by: Priyanshu Pandey <ppandey@purestorage.com>
1 parent afbb4b3 commit 8e2ffaf

3 files changed

Lines changed: 26 additions & 21 deletions

File tree

Dockerfile

Lines changed: 11 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -18,16 +18,19 @@ RUN python3 -m pip install awscli && python3 -m pip install rsa --upgrade
1818
RUN curl -q -o /usr/local/bin/aws-iam-authenticator https://amazon-eks.s3-us-west-2.amazonaws.com/1.10.3/2018-07-26/bin/linux/amd64/aws-iam-authenticator && \
1919
chmod +x /usr/local/bin/aws-iam-authenticator
2020

21+
#Install Google Cloud SDK
2122
ARG GCLOUD_SDK=google-cloud-sdk-418.0.0-linux-x86_64.tar.gz
22-
# Remove the test directories
23-
# Also don't need gsutil
23+
ARG GCLOUD_INSTALL_DIR="/usr/lib"
2424
RUN curl -q -o $GCLOUD_SDK https://dl.google.com/dl/cloudsdk/channels/rapid/downloads/$GCLOUD_SDK && \
25-
tar xf $GCLOUD_SDK && rm -rf $GCLOUD_SDK && \
26-
rm -rf /google-cloud-sdk/platform/gsutil/third_party/oauth2client/tests \
27-
/google-cloud-sdk/platform/gsutil/third_party/rsa/tests \
28-
/google-cloud-sdk/platform/gsutil/third_party/httplib2/python2/httplib2/test \
29-
/google-cloud-sdk/platform/gsutil && \
30-
python3 -m pip install pyyaml>=5.1 rsa>=4.0 urllib3>=1.24.2 --upgrade -t /google-cloud-sdk/lib/third_party
25+
tar xf $GCLOUD_SDK -C $GCLOUD_INSTALL_DIR && rm -rf $GCLOUD_SDK && \
26+
rm -rf $GCLOUD_INSTALL_DIR/google-cloud-sdk/platform/gsutil \
27+
$GCLOUD_INSTALL_DIR/google-cloud-sdk/RELEASE_NOTES
28+
ENV PATH "${PATH}:$GCLOUD_INSTALL_DIR/google-cloud-sdk/bin"
29+
#Install gke-gcloud-auth-plugin
30+
RUN gcloud components install gke-gcloud-auth-plugin
31+
#Create symlink /google-cloud-sdk/bin -> /usr/lib/google-cloud-sdk/bin for legacy cluster pair with gcp auth plugin
32+
RUN mkdir google-cloud-sdk
33+
RUN ln -s /usr/lib/google-cloud-sdk/bin /google-cloud-sdk/bin
3134

3235
WORKDIR /
3336

cmd/stork/stork.go

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@ package main
33
import (
44
"context"
55
"flag"
6-
"github.com/libopenstorage/stork/pkg/cache"
76
"net/http"
87
"os"
98
"os/signal"
@@ -23,6 +22,7 @@ import (
2322
_ "github.com/libopenstorage/stork/drivers/volume/portworx"
2423
"github.com/libopenstorage/stork/pkg/apis"
2524
"github.com/libopenstorage/stork/pkg/applicationmanager"
25+
"github.com/libopenstorage/stork/pkg/cache"
2626
"github.com/libopenstorage/stork/pkg/clusterdomains"
2727
"github.com/libopenstorage/stork/pkg/dbg"
2828
"github.com/libopenstorage/stork/pkg/extender"
@@ -209,6 +209,10 @@ func main() {
209209
},
210210
}
211211

212+
// Export USE_GKE_GCLOUD_AUTH_PLUGIN=True
213+
log.Warnf("Export USE_GKE_GCLOUD_AUTH_PLUGIN=True")
214+
os.Setenv("USE_GKE_GCLOUD_AUTH_PLUGIN", "True")
215+
212216
if err := app.Run(os.Args); err != nil {
213217
log.Fatalf("Error starting stork: %v", err)
214218
}

test/integration_test/Dockerfile

Lines changed: 10 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -8,18 +8,16 @@ RUN apt-get update && apt-get install -y python3-pip && apt-get install -y jq
88

99
RUN pip3 install --upgrade pip
1010

11-
ARG GCLOUD_SDK=google-cloud-sdk-269.0.0-linux-x86_64.tar.gz
12-
# Remove the test directories
13-
# Also don't need gsutil
14-
RUN wget https://dl.google.com/dl/cloudsdk/channels/rapid/downloads/$GCLOUD_SDK && \
15-
tar xf $GCLOUD_SDK && rm -rf $GCLOUD_SDK && \
16-
cp -r google-cloud-sdk/bin/* /usr/local/bin/ && \
17-
cp -r google-cloud-sdk/lib/* /usr/local/lib/ && \
18-
rm -rf /google-cloud-sdk/platform/gsutil/third_party/oauth2client/tests \
19-
/google-cloud-sdk/platform/gsutil/third_party/rsa/tests \
20-
/google-cloud-sdk/platform/gsutil/third_party/httplib2/python2/httplib2/test \
21-
/google-cloud-sdk/platform/gsutil && \
22-
python3 -m pip install pyyaml>=5.1 rsa>=4.0 urllib3>=1.24.2 --upgrade -t /google-cloud-sdk/lib/third_party
11+
#Install Google Cloud SDK
12+
ARG GCLOUD_SDK=google-cloud-sdk-418.0.0-linux-x86_64.tar.gz
13+
ARG GCLOUD_INSTALL_DIR="/usr/lib"
14+
RUN curl -q -o $GCLOUD_SDK https://dl.google.com/dl/cloudsdk/channels/rapid/downloads/$GCLOUD_SDK && \
15+
tar xf $GCLOUD_SDK -C $GCLOUD_INSTALL_DIR && rm -rf $GCLOUD_SDK && \
16+
rm -rf $GCLOUD_INSTALL_DIR/google-cloud-sdk/platform/gsutil \
17+
$GCLOUD_INSTALL_DIR/google-cloud-sdk/RELEASE_NOTES
18+
ENV PATH "${PATH}:$GCLOUD_INSTALL_DIR/google-cloud-sdk/bin"
19+
#Install gke-gcloud-auth-plugin
20+
RUN gcloud components install gke-gcloud-auth-plugin
2321

2422
RUN wget -O /usr/local/bin/aws-iam-authenticator https://amazon-eks.s3-us-west-2.amazonaws.com/1.10.3/2018-07-26/bin/linux/amd64/aws-iam-authenticator && \
2523
chmod +x /usr/local/bin/aws-iam-authenticator

0 commit comments

Comments
 (0)