Skip to content

Commit b157feb

Browse files
committed
Added changes to fix nil dereferencing in PrepareResourceForApply.
Signed-off-by: Kesavan Thiruvenkadasamy <kthiruvenkadasamy@purestorage.com>
1 parent 33dbeea commit b157feb

2 files changed

Lines changed: 4 additions & 2 deletions

File tree

pkg/applicationmanager/controllers/applicationclone.go

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -536,6 +536,7 @@ func (a *ApplicationCloneController) prepareResources(
536536
return nil, fmt.Errorf("error preparing PV resource %v: %v", metadata.GetName(), err)
537537
}
538538
}
539+
var opts resourcecollector.Options
539540
_, err = a.resourceCollector.PrepareResourceForApply(
540541
o,
541542
objects,
@@ -545,7 +546,7 @@ func (a *ApplicationCloneController) prepareResources(
545546
pvNameMappings,
546547
clone.Spec.IncludeOptionalResourceTypes,
547548
nil,
548-
nil,
549+
&opts,
549550
)
550551
if err != nil {
551552
return nil, err

pkg/applicationmanager/controllers/applicationrestore.go

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -605,6 +605,7 @@ func (a *ApplicationRestoreController) restoreVolumes(restore *storkapi.Applicat
605605
if (driverName == "csi" || driverName == "kdmp") && restore.Spec.ReplacePolicy == storkapi.ApplicationRestoreReplacePolicyDelete {
606606
objectMap := storkapi.CreateObjectsMap(restore.Spec.IncludeResources)
607607
objectBasedOnIncludeResources := make([]runtime.Unstructured, 0)
608+
var opts resourcecollector.Options
608609
for _, o := range objects {
609610
skip, err := a.resourceCollector.PrepareResourceForApply(
610611
o,
@@ -615,7 +616,7 @@ func (a *ApplicationRestoreController) restoreVolumes(restore *storkapi.Applicat
615616
nil,
616617
restore.Spec.IncludeOptionalResourceTypes,
617618
nil,
618-
nil,
619+
&opts,
619620
)
620621
if err != nil {
621622
return err

0 commit comments

Comments
 (0)