feat: add WithHTTPClient option#35
Open
lidel wants to merge 1 commit into
Open
Conversation
Requests always went through http.DefaultClient, so callers could not set timeouts, a proxy, custom TLS, or a caching transport. Add a WithHTTPClient option that threads a caller-supplied *http.Client through every DoH request; the default stays http.DefaultClient.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
DoH requests always went through
http.DefaultClient, with no way for callers to supply their own other than overriding the global client. That blocks setting a request timeout, routing through a proxy, customizing TLS, or putting a caching transport (or CDN-fronted client) in front of the resolver.Fix
WithHTTPClient(*http.Client)option that threads a caller-supplied client through every DoH request.http.DefaultClient, so behavior is unchanged when the option is unused.This makes the HTTP transport pluggable, which is the prerequisite for any of the above (timeouts, proxy, TLS, shared HTTP caching).