only count connections with pubsub streams in ip colocation factor#312
Open
vyzo wants to merge 2 commits into
Open
only count connections with pubsub streams in ip colocation factor#312vyzo wants to merge 2 commits into
vyzo wants to merge 2 commits into
Conversation
Collaborator
Author
|
I am going to add a test to satisfy the requirements of keeping coverage. |
yusefnapora
approved these changes
May 18, 2020
yusefnapora
left a comment
yusefnapora
left a comment
Contributor
There was a problem hiding this comment.
I'm sorry @vyzo, for some reason I thought I'd already reviewed this. It seems good to me 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
otherwise we might be vulnerable to active MITM attacks on secio.