Fix/error wrap envelope#3485
Open
bobsingh-dev wants to merge 2 commits intolibp2p:masterfrom
Open
Conversation
Contributor
|
This kind of change should be done more consistently through out the code base and not just limited these few lines. Searching for simple patterns using grep yields many more places where this change could be made. Use the following command to see more locations where this change could apply: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Wraps error using %w instead of %v to allow proper error unwrapping.
Why is this needed?
Using %w allows callers to use errors.Is and errors.As.
How to test?
go test ./...