Draft
Conversation
Adds a QUIC transport based on the upcoming Node.js PR [here](nodejs/node#62876). Currently you need to build a custom Node.js binary for the tests to pass using the instructions on the linked PR.
Member
Author
|
This has been on my hard drive in various forms since last summer so now that the Node.js PR has all the required features it's time to get it somewhere more visible. |
achingbrain
commented
Apr 24, 2026
|
|
||
| // TODO: have to copy before write otherwise error is thrown: | ||
| // TypeError: Provided key doesn't match [[ArrayBufferDetachKey]] | ||
| const bytes = data.subarray(0, toWrite).slice() |
Member
Author
There was a problem hiding this comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a QUIC transport based on the upcoming Node.js PR here.
Currently you need to build a custom Node.js binary for the tests to pass using the instructions on the linked PR.
There are lots of
@ts-expect-errorwhere types do not align, and TODOs to be resolved before this is ready.The code is based on the WebTransport and TCP transports, so expect some copy/paster and some options that are unused at the moment. Also a lot of the protections in the TCP transport around stopping accepting new connections are not present. These should really be pushed higher up into libp2p anyway so all transports can benefit from the protections.
Depends on:
Change checklist