Open
Conversation
achingbrain
force-pushed
the
chore/use-random-bytes-for-echo
branch
2 times, most recently
from
c6fb6f4 to
96e9950
Compare
Ensures that where bufs are split for sending, they are reassembled in the correct order.
achingbrain
force-pushed
the
chore/use-random-bytes-for-echo
branch
from
96e9950 to
e559d84
Compare
Member
|
was thinking of adding this before #3467 are you seeing issues? i was assuming libp2p ordered streams would catch it. looks like its passing :) |
Member
Author
|
More like a backfill. It would have caught https://bugzilla.mozilla.org/show_bug.cgi?id=1983831 unfortunately that was observed in the wild. |
Member
Author
|
Also I wasn't sure if this was covered elsewhere in the test suite - feel free to close if you don't think it's worth merging. |
Member
lets keep it. might as well do the same for many small writes as well. |
tabcat
reviewed
Apr 24, 2026
tabcat
reviewed
Apr 24, 2026
| const echoProtocol = dialer.services.echo.protocol | ||
|
|
||
| for (let i = 0; i < 2_000; i++) { | ||
| const input = new Uint8Array(1024).fill(5) |
Member
There was a problem hiding this comment.
might as well make this random too.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensures that where bufs are split for sending, they are reassembled in the correct order.
Change checklist