fix: resolve lint/test blockers and format TLS regression tests

Build RTCIceServer objects in WebRTC helpers to satisfy mypy, use a valid
generated certhash in the webrtc-direct multiaddr test, and apply ruff
parenthesized with-statement formatting in TLS regression tests.

Co-authored-by: Cursor <cursoragent@cursor.com>

Author: acul71

libp2p/transport/webrtc/_aiortc_helpers.py

@@ -19,6 +19,7 @@
 
 from aiortc import (
     RTCConfiguration,
+    RTCIceServer,
     RTCPeerConnection,
 )
 from aiortc.rtcdtlstransport import RTCCertificate
@@ -69,7 +70,10 @@ async def create_peer_connection(
     :param ice_servers: Optional STUN/TURN server URLs.
     :returns: A new peer connection.
     """
-    config = RTCConfiguration(iceServers=list(ice_servers) if ice_servers else [])
+    ice_server_list = (
+        [RTCIceServer(urls=[url]) for url in ice_servers] if ice_servers else []
+    )
+    config = RTCConfiguration(iceServers=ice_server_list)
     pc = RTCPeerConnection(configuration=config)
     # Replace aiortc's auto-generated cert.  Must use the mangled name —
     # aiortc reads only `self.__certificates`, which mangles to this.

tests/core/security/tls/test_tls.py

@@ -36,9 +36,10 @@ async def test_secure_inbound_rejects_missing_client_certificate() -> None:
     mock_conn = MagicMock()
     mock_rw = _mock_tls_reader_writer_no_cert()
 
-    with patch(
-        "libp2p.security.tls.transport.TLSReadWriter", return_value=mock_rw
-    ), pytest.raises(TLSHandshakeFailure, match="no client certificate"):
+    with (
+        patch("libp2p.security.tls.transport.TLSReadWriter", return_value=mock_rw),
+        pytest.raises(TLSHandshakeFailure, match="no client certificate"),
+    ):
         await transport.secure_inbound(mock_conn)
 
 
@@ -49,9 +50,7 @@ async def test_upgrader_rejects_missing_client_certificate(nursery) -> None:
     upgrader = TransportUpgrader(sec_opt, default_mplex_muxer_transport_factory())
     mock_rw = _mock_tls_reader_writer_no_cert()
 
-    with patch(
-        "libp2p.security.tls.transport.TLSReadWriter", return_value=mock_rw
-    ):
+    with patch("libp2p.security.tls.transport.TLSReadWriter", return_value=mock_rw):
         async with raw_conn_factory(nursery) as (_local_conn, remote_conn):
             with pytest.raises(SecurityUpgradeFailure):
                 await upgrader.upgrade_security(remote_conn, False)

tests/core/transport/webrtc/test_multiaddr_utils.py

@@ -23,8 +23,10 @@ def test_valid_ipv4_webrtc_direct(self):
         assert is_webrtc_direct_multiaddr(maddr)
 
     def test_valid_ipv4_with_certhash(self):
+        cert = WebRTCCertificate.generate()
+        certhash = cert.fingerprint_to_multibase()
         maddr = Multiaddr(
-            "/ip4/192.168.1.1/udp/4001/webrtc-direct/certhash/uEiBkEKoo3S"
+            f"/ip4/192.168.1.1/udp/4001/webrtc-direct/certhash/{certhash}"
         )
         assert is_webrtc_direct_multiaddr(maddr)