Fix intermittent seven-node dummyaccount CI flake#1358
Merged
Conversation
Replace fixed post-connect sleep with event-driven pubsub readiness checks and mark seven-node tree tests as flaky under CI load. Fixes libp2p#1353 Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1353
Summary
trio.sleep(0.25)in dummyaccount topology tests with event-driven pubsub readiness (wait_for_peer+wait_for_subscriptionper adjacency edge)@pytest.mark.flaky(reruns=3, reruns_delay=2)to the three seven-node tree tests as a CI safety netTest plan
pytest tests/core/pubsub/test_dummyaccount_demo.py -n autopytest tests/core/pubsub/test_dummyaccount_demo.py -k "seven_nodes_tree" -n auto(5 consecutive runs)make pr && make docspass locallyMade with Cursor