fix(quic): satisfy mypy 2.2 comparison-overlap in stream read loop#1374
Merged
Conversation
Use is_reset() in the QUICStream.read() wait loop so concurrent peer resets remain detectable without tripping mypy 2.2 comparison-overlap after the entry state guard. Fixes #1373 Co-authored-by: Cursor <cursoragent@cursor.com>
This was referenced Jul 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mainCI lint failure (tox * lint) caused by mypy 2.2comparison-overlapinQUICStream.read()self._state == StreamState.RESETin the read wait loop withself.is_reset()— same runtime behavior, mypy-safeCloses #1373
Problem
After #1372 merged,
mainlint jobs failed on a pre-existing QUIC stream check (unrelated to interop changes). CI resolves mypy 2.2.0; local dev envs on mypy 1.x did not catch it.Test plan
make lint/make typecheckwith mypy 2.2.0pytest tests/core/transport/quic/(140 passed, including new regression test)make linux-docsad1eb6ae(main before fix(interop): handle IPv6-only multiaddrs in _get_ip_value #1372):make test— 3047 passed, 1 failed (test_gossipsub_identify_aware_publish.py::test_publish_before_identify_completes), 23 skipped; no regressions introduced by this PRMade with Cursor