feat: make wasm features implicit by hanabi1224 · Pull Request #6102 · libp2p/rust-libp2p

hanabi1224 · 2025-07-16T13:51:18Z

Description

This PR tries to make wasm-bindgen features implicit

Notes & open questions

Change checklist

I have performed a self-review of my own code
I have made corresponding changes to the documentation
I have added tests that prove my fix is effective or that my feature works
A changelog entry has been made in the appropriate crates

elenaf9 · 2025-07-18T08:39:27Z

Thanks for the PR @hanabi1224.

I think this is a small improvement that would be nice to have. However, it is a breaking change in libp2p-swarm, which unfortunately requires us to also bump and release all libp2p protocols that depend on libp2p-swarm. This is overall quite painful and imo not worth it right now, especially because current users will already have enabled the wasm-bindgen feature.
I would delay this PR until the next required breaking change of libp2p-swarm.
cc @jxs

dariusc93 · 2025-07-22T01:27:27Z

Since we will delay this, I will move this to draft for now.

elenaf9

Once #6273 is in we can also merge this.

Remove approval to prevent accidental merge.

elenaf9

One CHANGELOG nit, rest LGTM. Thanks @hanabi1224!

Co-authored-by: Elena Frank <elena.frank@proton.me>

elenaf9 · 2026-04-20T16:22:46Z

Thanks!

mergify · 2026-04-20T16:23:13Z

Merge Queue Status

✅ Entered queue — 2026-04-20 16:23 UTC · Rule: default
✅ Checks skipped · PR is already up-to-date
✅ Merged — 2026-04-20 16:23 UTC · at 516b772cbe188a956233bd2aacc7c52c80a27ba7 · squash

This pull request spent 12 seconds in the queue, including 2 seconds running CI.

Required conditions to merge

#approved-reviews-by >= 1 [🛡 GitHub branch protection]
- feat: make wasm features implicit #6102
#changes-requested-reviews-by = 0 [🛡 GitHub branch protection]
- feat: make wasm features implicit #6102
#review-threads-unresolved = 0 [🛡 GitHub branch protection]
- feat: make wasm features implicit #6102
any of [🛡 GitHub branch protection]:
- check-success = Check rustdoc intra-doc links
- check-neutral = Check rustdoc intra-doc links
- check-skipped = Check rustdoc intra-doc links
any of [🛡 GitHub branch protection]:
- check-success = rustfmt
- check-neutral = rustfmt
- check-skipped = rustfmt
any of [🛡 GitHub branch protection]:
- check-success = Test libp2p-metrics
- check-neutral = Test libp2p-metrics
- check-skipped = Test libp2p-metrics
any of [🛡 GitHub branch protection]:
- check-success = Compile on x86_64-apple-darwin
- check-neutral = Compile on x86_64-apple-darwin
- check-skipped = Compile on x86_64-apple-darwin
any of [🛡 GitHub branch protection]:
- check-success = Compile on x86_64-pc-windows-msvc
- check-neutral = Compile on x86_64-pc-windows-msvc
- check-skipped = Compile on x86_64-pc-windows-msvc
any of [🛡 GitHub branch protection]:
- check-success = Test libp2p-yamux
- check-neutral = Test libp2p-yamux
- check-skipped = Test libp2p-yamux
any of [🛡 GitHub branch protection]:
- check-success = Test libp2p-swarm
- check-neutral = Test libp2p-swarm
- check-skipped = Test libp2p-swarm
any of [🛡 GitHub branch protection]:
- check-success = Test libp2p-mdns
- check-neutral = Test libp2p-mdns
- check-skipped = Test libp2p-mdns
any of [🛡 GitHub branch protection]:
- check-success = Test libp2p-relay
- check-neutral = Test libp2p-relay
- check-skipped = Test libp2p-relay
any of [🛡 GitHub branch protection]:
- check-success = Test libp2p-uds
- check-neutral = Test libp2p-uds
- check-skipped = Test libp2p-uds
any of [🛡 GitHub branch protection]:
- check-success = Test libp2p-rendezvous
- check-neutral = Test libp2p-rendezvous
- check-skipped = Test libp2p-rendezvous
any of [🛡 GitHub branch protection]:
- check-success = Test libp2p
- check-neutral = Test libp2p
- check-skipped = Test libp2p
any of [🛡 GitHub branch protection]:
- check-success = Test libp2p-noise
- check-neutral = Test libp2p-noise
- check-skipped = Test libp2p-noise
any of [🛡 GitHub branch protection]:
- check-success = Test libp2p-gossipsub
- check-neutral = Test libp2p-gossipsub
- check-skipped = Test libp2p-gossipsub
any of [🛡 GitHub branch protection]:
- check-success = Test rw-stream-sink
- check-neutral = Test rw-stream-sink
- check-skipped = Test rw-stream-sink
any of [🛡 GitHub branch protection]:
- check-success = Test libp2p-dns
- check-neutral = Test libp2p-dns
- check-skipped = Test libp2p-dns
any of [🛡 GitHub branch protection]:
- check-success = Test libp2p-floodsub
- check-neutral = Test libp2p-floodsub
- check-skipped = Test libp2p-floodsub
any of [🛡 GitHub branch protection]:
- check-success = Test libp2p-swarm-derive
- check-neutral = Test libp2p-swarm-derive
- check-skipped = Test libp2p-swarm-derive
any of [🛡 GitHub branch protection]:
- check-success = Test libp2p-pnet
- check-neutral = Test libp2p-pnet
- check-skipped = Test libp2p-pnet
any of [🛡 GitHub branch protection]:
- check-success = Test libp2p-tls
- check-neutral = Test libp2p-tls
- check-skipped = Test libp2p-tls
any of [🛡 GitHub branch protection]:
- check-success = Test multistream-select
- check-neutral = Test multistream-select
- check-skipped = Test multistream-select
any of [🛡 GitHub branch protection]:
- check-success = Test libp2p-kad
- check-neutral = Test libp2p-kad
- check-skipped = Test libp2p-kad
any of [🛡 GitHub branch protection]:
- check-success = Test libp2p-core
- check-neutral = Test libp2p-core
- check-skipped = Test libp2p-core
any of [🛡 GitHub branch protection]:
- check-success = Test libp2p-tcp
- check-neutral = Test libp2p-tcp
- check-skipped = Test libp2p-tcp
any of [🛡 GitHub branch protection]:
- check-success = Test libp2p-websocket
- check-neutral = Test libp2p-websocket
- check-skipped = Test libp2p-websocket
any of [🛡 GitHub branch protection]:
- check-success = IPFS Integration tests
- check-neutral = IPFS Integration tests
- check-skipped = IPFS Integration tests
any of [🛡 GitHub branch protection]:
- check-success = Test libp2p-identify
- check-neutral = Test libp2p-identify
- check-skipped = Test libp2p-identify
any of [🛡 GitHub branch protection]:
- check-success = Test libp2p-dcutr
- check-neutral = Test libp2p-dcutr
- check-skipped = Test libp2p-dcutr
any of [🛡 GitHub branch protection]:
- check-success = Compile on wasm32-unknown-emscripten
- check-neutral = Compile on wasm32-unknown-emscripten
- check-skipped = Compile on wasm32-unknown-emscripten
any of [🛡 GitHub branch protection]:
- check-success = Compile with select features (mdns tcp dns tokio)
- check-neutral = Compile with select features (mdns tcp dns tokio)
- check-skipped = Compile with select features (mdns tcp dns tokio)
any of [🛡 GitHub branch protection]:
- check-success = Test libp2p-request-response
- check-neutral = Test libp2p-request-response
- check-skipped = Test libp2p-request-response
any of [🛡 GitHub branch protection]:
- check-success = Compile on wasm32-unknown-unknown
- check-neutral = Compile on wasm32-unknown-unknown
- check-skipped = Compile on wasm32-unknown-unknown
any of [🛡 GitHub branch protection]:
- check-success = Test libp2p-mplex
- check-neutral = Test libp2p-mplex
- check-skipped = Test libp2p-mplex
any of [🛡 GitHub branch protection]:
- check-success = Test libp2p-ping
- check-neutral = Test libp2p-ping
- check-skipped = Test libp2p-ping
any of [🛡 GitHub branch protection]:
- check-success = Test libp2p-plaintext
- check-neutral = Test libp2p-plaintext
- check-skipped = Test libp2p-plaintext
any of [🛡 GitHub branch protection]:
- check-success = Test libp2p-autonat
- check-neutral = Test libp2p-autonat
- check-skipped = Test libp2p-autonat
any of [🛡 GitHub branch protection]:
- check-success = Test libp2p-quic
- check-neutral = Test libp2p-quic
- check-skipped = Test libp2p-quic
any of [🛡 GitHub branch protection]:
- check-success = Test libp2p-webrtc
- check-neutral = Test libp2p-webrtc
- check-skipped = Test libp2p-webrtc
any of [🛡 GitHub branch protection]:
- check-success = Test quick-protobuf-codec
- check-neutral = Test quick-protobuf-codec
- check-skipped = Test quick-protobuf-codec
any of [🛡 GitHub branch protection]:
- check-success = Test libp2p-identity
- check-neutral = Test libp2p-identity
- check-skipped = Test libp2p-identity
any of [🛡 GitHub branch protection]:
- check-success = Test libp2p-allow-block-list
- check-neutral = Test libp2p-allow-block-list
- check-skipped = Test libp2p-allow-block-list
any of [🛡 GitHub branch protection]:
- check-success = Test libp2p-swarm-test
- check-neutral = Test libp2p-swarm-test
- check-skipped = Test libp2p-swarm-test
any of [🛡 GitHub branch protection]:
- check-success = Check for changes in proto files
- check-neutral = Check for changes in proto files
- check-skipped = Check for changes in proto files
any of [🛡 GitHub branch protection]:
- check-success = Ensure that Cargo.lock is up-to-date
- check-neutral = Ensure that Cargo.lock is up-to-date
- check-skipped = Ensure that Cargo.lock is up-to-date
any of [🛡 GitHub branch protection]:
- check-success = Test libp2p-connection-limits
- check-neutral = Test libp2p-connection-limits
- check-skipped = Test libp2p-connection-limits
any of [🛡 GitHub branch protection]:
- check-success = examples
- check-neutral = examples
- check-skipped = examples
any of [🛡 GitHub branch protection]:
- check-success = Run all WASM tests
- check-neutral = Run all WASM tests
- check-skipped = Run all WASM tests
any of [🛡 GitHub branch protection]:
- check-success = Test libp2p-memory-connection-limits
- check-neutral = Test libp2p-memory-connection-limits
- check-skipped = Test libp2p-memory-connection-limits
any of [🛡 GitHub branch protection]:
- check-success = Test libp2p-webtransport-websys
- check-neutral = Test libp2p-webtransport-websys
- check-skipped = Test libp2p-webtransport-websys
any of [🛡 GitHub branch protection]:
- check-success = Test libp2p-perf
- check-neutral = Test libp2p-perf
- check-skipped = Test libp2p-perf
any of [🛡 GitHub branch protection]:
- check-success = Compile with MSRV
- check-neutral = Compile with MSRV
- check-skipped = Compile with MSRV
any of [🛡 GitHub branch protection]:
- check-success = manifest_lint
- check-neutral = manifest_lint
- check-skipped = manifest_lint
any of [🛡 GitHub branch protection]:
- check-success = Test libp2p-server
- check-neutral = Test libp2p-server
- check-skipped = Test libp2p-server
any of [🛡 GitHub branch protection]:
- check-success = Compile on wasm32-wasip1
- check-neutral = Compile on wasm32-wasip1
- check-skipped = Compile on wasm32-wasip1

hanabi1224 force-pushed the implicit-wasm-feature branch 3 times, most recently from 9893a50 to 5bf3e09 Compare July 16, 2025 14:21

fix: make wasm features implicit

97a5dd4

hanabi1224 force-pushed the implicit-wasm-feature branch from 5bf3e09 to 97a5dd4 Compare July 16, 2025 14:22

hanabi1224 marked this pull request as ready for review July 16, 2025 14:42

Merge branch 'master' into implicit-wasm-feature

ad8e0a9

elenaf9 added the delay-breaking-change label Jul 18, 2025

fix dep order

ac081b2

hanabi1224 mentioned this pull request Jul 18, 2025

chore(deps): bump rand in identity and core #6092

Closed

4 tasks

dariusc93 marked this pull request as draft July 22, 2025 01:27

hanabi1224 added 4 commits August 15, 2025 08:20

Merge remote-tracking branch 'origin/master' into implicit-wasm-feature

122ed91

Merge branch 'master' into implicit-wasm-feature

317edc6

Merge remote-tracking branch 'origin/master' into implicit-wasm-feature

0112d39

Merge remote-tracking branch 'origin/master' into implicit-wasm-feature

43e3fa2

hanabi1224 force-pushed the implicit-wasm-feature branch from 1b0defd to 43e3fa2 Compare March 17, 2026 15:06

elenaf9 previously approved these changes Mar 17, 2026

View reviewed changes

elenaf9 reviewed Mar 17, 2026

View reviewed changes

Comment thread libp2p/Cargo.toml

Comment thread protocols/gossipsub/Cargo.toml

elenaf9 changed the title ~~fix: make wasm features implicit~~ feat: make wasm features implicit Mar 17, 2026

hanabi1224 and others added 3 commits March 23, 2026 08:57

Merge branch 'master' into implicit-wasm-feature

32689ba

Merge remote-tracking branch 'origin/master' into implicit-wasm-feature

78a0e46

Merge branch 'master' into implicit-wasm-feature

a80df0f

elenaf9 approved these changes Apr 20, 2026

View reviewed changes

Comment thread libp2p/CHANGELOG.md Outdated

Update libp2p/CHANGELOG.md

516b772

Co-authored-by: Elena Frank <elena.frank@proton.me>

hanabi1224 marked this pull request as ready for review April 20, 2026 10:26

elenaf9 added send-it and removed delay-breaking-change labels Apr 20, 2026

mergify Bot added the queued label Apr 20, 2026

mergify Bot merged commit 31e80b4 into libp2p:master Apr 20, 2026
69 of 71 checks passed

mergify Bot removed the queued label Apr 20, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: make wasm features implicit#6102

feat: make wasm features implicit#6102
mergify[bot] merged 11 commits intolibp2p:masterfrom
hanabi1224:implicit-wasm-feature

hanabi1224 commented Jul 16, 2025 •

edited

Loading

Uh oh!

elenaf9 commented Jul 18, 2025

Uh oh!

dariusc93 commented Jul 22, 2025

Uh oh!

elenaf9 left a comment •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

elenaf9 left a comment

Uh oh!

Uh oh!

elenaf9 commented Apr 20, 2026

Uh oh!

mergify Bot commented Apr 20, 2026 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

hanabi1224 commented Jul 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Notes & open questions

Change checklist

Uh oh!

elenaf9 commented Jul 18, 2025

Uh oh!

dariusc93 commented Jul 22, 2025

Uh oh!

elenaf9 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

elenaf9 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

elenaf9 commented Apr 20, 2026

Uh oh!

mergify Bot commented Apr 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge Queue Status

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

hanabi1224 commented Jul 16, 2025 •

edited

Loading

elenaf9 left a comment •

edited

Loading

mergify Bot commented Apr 20, 2026 •

edited

Loading