fix(relay): enforce per-peer reservation limit at boundary#6365
Open
failuresmith wants to merge 2 commits intolibp2p:masterfrom
Open
fix(relay): enforce per-peer reservation limit at boundary#6365failuresmith wants to merge 2 commits intolibp2p:masterfrom
failuresmith wants to merge 2 commits intolibp2p:masterfrom
Conversation
elenaf9
reviewed
Apr 20, 2026
Comment on lines
+354
to
+361
| let relay_addr = Multiaddr::empty().with(Protocol::Memory(rand::random::<u64>())); | ||
| let mut relay = build_relay_with_config(relay::Config { | ||
| max_reservations: 10, | ||
| max_reservations_per_peer: 1, | ||
| reservation_duration: Duration::from_secs(60), | ||
| ..relay::Config::default() | ||
| }); | ||
| let relay_peer_id = *relay.local_peer_id(); |
Member
There was a problem hiding this comment.
The test is very much appreciated, thanks!
The test right now creates two clients with the same peer ID, because the client behavior can have only one reservation per connection at a time.
I think we can simplify this quite a lot by instead adding two listen addresses for the relay and have one client try to use both addresses (which internally will then create two connections between client and relay).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PeerIdRoot cause
The relay admission check used
>instead of>=when evaluatingmax_reservations_per_peer, which allowed one extra reservation when a peer was already exactly at the configured limit.Validation
cargo fmt --checkcargo test -p libp2p-relay