Skip to content

feat(rendezvous): make /rendezvous/1.0.0/ public#6469

Open
12TreeMan31 wants to merge 3 commits into
libp2p:masterfrom
12TreeMan31:master
Open

feat(rendezvous): make /rendezvous/1.0.0/ public#6469
12TreeMan31 wants to merge 3 commits into
libp2p:masterfrom
12TreeMan31:master

Conversation

@12TreeMan31
Copy link
Copy Markdown

@12TreeMan31 12TreeMan31 commented Jun 4, 2026

Description

This PR exposes PROTOCOL_NAME, which contains the rendezvous protocol ID.

Unlike many other protocols, rendezvous does not currently provide its protocol ID to the public. Exposing PROTOCOL_NAME makes it more consistent.

closes: #6174

AI Assistance Disclosure

Tools used (required — write none if no AI was used): none

Attestation (required):

  • I have read every line of this diff, understand what it does, and can explain it in review.

Notes & open questions

I did change PROTOCOL_IDENT to PROTOCOL_NAME because thats how other protocols named their ID's from what I've seen.

This is my first ever PR, I hope I did everything correct.

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • A changelog entry has been made in the appropriate crates

@12TreeMan31 12TreeMan31 marked this pull request as ready for review June 4, 2026 01:56
@dariusc93 dariusc93 requested a review from jxs June 4, 2026 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rendezvous: Make /rendezvous/1.0.0 public

2 participants