Skip to content

Commit 7c31158

Browse files
committed
fix: replace C++20 designated initializers with C++17-compatible syntax in tests
The CI build failed because constraint_parser_test.cpp used designated initializers ({.case_sensitive = true}), which require C++20 or later. Also fix lcov mismatch error in CI coverage report generation.
1 parent 435cd0a commit 7c31158

2 files changed

Lines changed: 5 additions & 3 deletions

File tree

.github/workflows/ci.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,7 @@ jobs:
8383
- name: Generate coverage report
8484
run: |
8585
mkdir -p build/coverage
86-
lcov --directory build --capture --output-file build/coverage/coverage.info --ignore-errors source,gcov
86+
lcov --directory build --capture --output-file build/coverage/coverage.info --ignore-errors source,gcov,mismatch
8787
lcov --extract build/coverage/coverage.info "${PWD}/src/*" --output-file build/coverage/coverage_filtered.info --ignore-errors unused
8888
8989
- name: Upload coverage to Codecov

tests/model/constraint_parser_test.cpp

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -443,7 +443,8 @@ TEST(ConstraintParserTest, CaseInsensitiveDefault) {
443443

444444
TEST(ConstraintParserTest, CaseSensitiveFails) {
445445
std::vector<Parameter> params = {{"os", {"win", "mac"}, {}}};
446-
coverwise::model::ParseOptions opts{.case_sensitive = true};
446+
coverwise::model::ParseOptions opts;
447+
opts.case_sensitive = true;
447448

448449
// "OS" does not match "os" in case-sensitive mode.
449450
auto result = ParseConstraint("OS=Win", params, opts);
@@ -452,7 +453,8 @@ TEST(ConstraintParserTest, CaseSensitiveFails) {
452453

453454
TEST(ConstraintParserTest, CaseSensitiveExactMatch) {
454455
std::vector<Parameter> params = {{"os", {"win", "mac"}, {}}};
455-
coverwise::model::ParseOptions opts{.case_sensitive = true};
456+
coverwise::model::ParseOptions opts;
457+
opts.case_sensitive = true;
456458

457459
// Exact case matches succeed.
458460
auto result = ParseConstraint("os=win", params, opts);

0 commit comments

Comments
 (0)