fix(e2e): order the workspace module ahead of the DCR and connector

The workspace id output resolves once the workspace exists, not once its
custom tables and Sentinel onboarding finish, so the DCR (whose Custom-<table>
output stream targets the custom table) and the connector definition (which
needs the workspace onboarded) could race ahead. Add depends_on = [module.law]
to both example stacks so the table exists and onboarding completes first; the
connector module retry regex still backstops residual onboarding propagation.

Author: craigthackerx

examples/complete/main.tf

@@ -61,6 +61,11 @@ module "data_collection" {
   source  = "libre-devops/data-collection/azurerm"
   version = "~> 4.0"
 
+  # The DCR output stream (Custom-<table>) targets the destination custom table, so the table must
+  # exist first. The workspace id output resolves once the workspace exists, not once its custom
+  # tables finish, so order the whole workspace module ahead of the DCR explicitly.
+  depends_on = [module.law]
+
   resource_group_id = module.rg.ids[local.rg_name]
   location          = local.location
   tags              = module.tags.tags
@@ -102,6 +107,12 @@ module "data_collection" {
 module "codeless_connector" {
   source = "../../"
 
+  # The connector definition is created under the Sentinel-onboarded workspace. Onboarding is a
+  # separate resource inside the workspace module that the workspace id output does not wait for, so
+  # order the whole module ahead of the connector; the module's retry regex covers residual
+  # onboarding propagation lag after that.
+  depends_on = [module.law]
+
   workspace_id    = module.law.workspace_ids[local.law_name]
   definition_name = "ldo-example-multi-connector"
 

examples/minimal/main.tf

@@ -66,6 +66,11 @@ module "data_collection" {
   source  = "libre-devops/data-collection/azurerm"
   version = "~> 4.0"
 
+  # The DCR output stream (Custom-<table>) targets the destination custom table, so the table must
+  # exist first. The workspace id output resolves once the workspace exists, not once its custom
+  # tables finish, so order the whole workspace module ahead of the DCR explicitly.
+  depends_on = [module.law]
+
   resource_group_id = module.rg.ids[local.rg_name]
   location          = local.location
   tags              = module.tags.tags
@@ -108,6 +113,12 @@ module "data_collection" {
 module "codeless_connector" {
   source = "../../"
 
+  # The connector definition is created under the Sentinel-onboarded workspace. Onboarding is a
+  # separate resource inside the workspace module that the workspace id output does not wait for, so
+  # order the whole module ahead of the connector; the module's retry regex covers residual
+  # onboarding propagation lag after that.
+  depends_on = [module.law]
+
   workspace_id    = module.law.workspace_ids[local.law_name]
   definition_name = "ldo-github-advisories"