Skip to content

Commit 0ed2e72

Browse files
committed
docs(editor): fix duplicated paragraph from dev merge resolution
The 'dev' merge into this branch left two redundant descriptions of the completion provider in Section 2 (one from #84, one from #85). Collapsed into a single accurate paragraph: registerSQLCompletionProvider -> registerCompletion ItemProvider('sql', …) with trigger characters '.' and space, registered from QueryEditor.tsx. Verified triggerCharacters ['.', ' '] at sql-completions.ts:121.
1 parent 3225743 commit 0ed2e72

1 file changed

Lines changed: 4 additions & 7 deletions

File tree

docs/editor/sql-alias-completion.md

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -84,13 +84,10 @@ Lightweight regex-based SQL parser that extracts table aliases without external
8484

8585
#### 2. Completion Provider (`src/lib/editor/sql-completions.ts`)
8686

87-
Monaco Editor completion provider (`registerCompletionItemProvider('sql', …)`, triggered on `.` and
88-
space) that integrates with the alias extractor. Registered by the editor and hosted in
89-
`src/components/QueryEditor.tsx`.
90-
Monaco Editor completion provider that integrates with the alias extractor. The
91-
provider is implemented as `registerSQLCompletionProvider(monaco, schemaCompletionCache)`
92-
and registered from `src/components/QueryEditor.tsx` (in an `useEffect` that returns the
93-
disposable for cleanup).
87+
Monaco Editor completion provider that integrates with the alias extractor. It is implemented as
88+
`registerSQLCompletionProvider(monaco, schemaCompletionCache)`, which calls
89+
`registerCompletionItemProvider('sql', …)` with trigger characters `.` and space. It is registered
90+
from `src/components/QueryEditor.tsx` in a `useEffect` that returns the disposable for cleanup.
9491

9592
**Dot-triggered completion flow:**
9693
```

0 commit comments

Comments
 (0)