Skip to content

Commit 3225743

Browse files
committed
docs(helm): clarify seed-connection env source + configurable mount (Copilot)
Addresses two Copilot review notes on HELM_CHART.md: - SEED_CONFIG_PATH / SEED_CACHE_TTL_MS are set directly on the Deployment (deployment.yaml:118-120), not via the app ConfigMap — table Source column + section intro clarified. - Seed §8: the mount filename is configurable via seedConnections.configMapKey (default seed-connections.yaml), and enabling the feature without seedConnections.config OR existingConfigMap provisions nothing. The third Copilot note (FEATURES.md:56, Redis 'CLIENT LIST') is a false positive — getActiveSessions() uses this.client.client('LIST') at redis.ts:455 (ioredis exposes CLIENT LIST as .client('LIST')), so the doc and CLAUDE.md are correct. No change.
1 parent c331a9c commit 3225743

1 file changed

Lines changed: 4 additions & 4 deletions

File tree

docs/HELM_CHART.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -147,7 +147,7 @@ Subchart secret name follows Bitnami convention: `<release-name>-postgresql` (no
147147
148148
### 6. ConfigMap / Environment Variables
149149
150-
All non-sensitive configuration flows through a ConfigMap:
150+
Most non-sensitive configuration flows through a ConfigMap (the seed-connection vars are the exception — see the note below the table):
151151
152152
| Variable | Source | Conditional |
153153
|----------|--------|-------------|
@@ -159,7 +159,7 @@ All non-sensitive configuration flows through a ConfigMap:
159159
| `NEXT_PUBLIC_AUTH_PROVIDER` | `authProvider` | Always |
160160
| `STORAGE_PROVIDER` | Auto-wired (see above) | Always |
161161
| `STORAGE_SQLITE_PATH` | `config.storageSqlitePath` | When sqlite |
162-
| `SEED_CONFIG_PATH` / `SEED_CACHE_TTL_MS` | `seedConnections.*` | When `seedConnections.enabled` |
162+
| `SEED_CONFIG_PATH` / `SEED_CACHE_TTL_MS` | `seedConnections.*` — set **directly on the Deployment** (not via the ConfigMap) | When `seedConnections.enabled` |
163163
| `LLM_PROVIDER/MODEL/API_URL` | `config.llm*` | When set |
164164
| `OIDC_*` | `config.oidc*` | When `authProvider=oidc` |
165165
@@ -181,8 +181,8 @@ Any change to configuration values triggers a rolling restart automatically.
181181

182182
When `seedConnections.enabled=true`, the chart provisions a set of pre-defined database connections at startup:
183183

184-
- Connection definitions come from inline `seedConnections.config` (rendered into `seed-configmap.yaml`) or an `existingConfigMap`.
185-
- The deployment mounts the config at `/app/config/seed-connections.yaml` and sets `SEED_CONFIG_PATH` (plus `SEED_CACHE_TTL_MS` from `seedConnections.cacheTTL`).
184+
- You must supply the definitions via **either** inline `seedConnections.config` (rendered into `seed-configmap.yaml`) **or** an `existingConfigMap`. Enabling the feature without providing one of these provisions nothing.
185+
- The deployment mounts the ConfigMap at `/app/config/<key>`, where `<key>` is `seedConnections.configMapKey` (default `seed-connections.yaml`), and sets `SEED_CONFIG_PATH` to that path (plus `SEED_CACHE_TTL_MS` from `seedConnections.cacheTTL`). These two env vars are set on the Deployment directly, not through the app ConfigMap.
186186
- Credentials referenced by the seed config resolve from environment/secret at runtime, so secrets stay out of the ConfigMap.
187187

188188
## Release Pipeline

0 commit comments

Comments
 (0)