You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
docs(helm): clarify seed-connection env source + configurable mount (Copilot)
Addresses two Copilot review notes on HELM_CHART.md:
- SEED_CONFIG_PATH / SEED_CACHE_TTL_MS are set directly on the Deployment
(deployment.yaml:118-120), not via the app ConfigMap — table Source column +
section intro clarified.
- Seed §8: the mount filename is configurable via seedConnections.configMapKey
(default seed-connections.yaml), and enabling the feature without
seedConnections.config OR existingConfigMap provisions nothing.
The third Copilot note (FEATURES.md:56, Redis 'CLIENT LIST') is a false
positive — getActiveSessions() uses this.client.client('LIST') at
redis.ts:455 (ioredis exposes CLIENT LIST as .client('LIST')), so the doc
and CLAUDE.md are correct. No change.
| `STORAGE_PROVIDER` | Auto-wired (see above) | Always |
161
161
| `STORAGE_SQLITE_PATH` | `config.storageSqlitePath` | When sqlite |
162
-
| `SEED_CONFIG_PATH` / `SEED_CACHE_TTL_MS` | `seedConnections.*` | When `seedConnections.enabled` |
162
+
| `SEED_CONFIG_PATH` / `SEED_CACHE_TTL_MS` | `seedConnections.*` — set **directly on the Deployment** (not via the ConfigMap) | When `seedConnections.enabled` |
163
163
| `LLM_PROVIDER/MODEL/API_URL` | `config.llm*` | When set |
164
164
| `OIDC_*` | `config.oidc*` | When `authProvider=oidc` |
165
165
@@ -181,8 +181,8 @@ Any change to configuration values triggers a rolling restart automatically.
181
181
182
182
When `seedConnections.enabled=true`, the chart provisions a set of pre-defined database connections at startup:
183
183
184
-
-Connection definitions come from inline `seedConnections.config` (rendered into `seed-configmap.yaml`) or an `existingConfigMap`.
185
-
- The deployment mounts the config at `/app/config/seed-connections.yaml` and sets `SEED_CONFIG_PATH` (plus `SEED_CACHE_TTL_MS` from `seedConnections.cacheTTL`).
184
+
-You must supply the definitions via **either** inline `seedConnections.config` (rendered into `seed-configmap.yaml`) **or** an `existingConfigMap`. Enabling the feature without providing one of these provisions nothing.
185
+
- The deployment mounts the ConfigMap at `/app/config/<key>`, where `<key>` is `seedConnections.configMapKey` (default `seed-connections.yaml`), and sets `SEED_CONFIG_PATH`to that path (plus `SEED_CACHE_TTL_MS` from `seedConnections.cacheTTL`). These two env vars are set on the Deployment directly, not through the app ConfigMap.
186
186
- Credentials referenced by the seed config resolve from environment/secret at runtime, so secrets stay out of the ConfigMap.
0 commit comments