fix(sql): quote schema-qualified table names per-segment (0.9.23) (#70)

* fix(sql): quote schema-qualified table names per-segment

The dialect-aware quoteIdentifier treated a schema-qualified table name as a
single identifier, so 'employees.department' became '"employees.department"' —
which Postgres reads as one relation literally named with a dot, failing with a
query error. Sidebar 'select top 100' on any schema-qualified table was broken.

Add quoteQualifiedName(): split on '.', quote each segment only-when-needed, and
rejoin. 'employees.department' stays unquoted; 'public.Order' becomes
'public."Order"'. Use it for table names in the query generators and the data
profiler (columns still use single-identifier quoting).

Verified end-to-end against a Neon Postgres database: the generated
'SELECT * FROM employees.department LIMIT 50;' runs, whereas the old quoted form
failed.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* chore(package): bump version to 0.9.23

---------

Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Author: cevheri

package.json

@@ -1,6 +1,6 @@
 {
   "name": "@libredb/studio",
-  "version": "0.9.22",
+  "version": "0.9.23",
   "private": false,
   "publishConfig": {
     "access": "public"

src/app/api/db/profile/route.ts

@@ -3,7 +3,7 @@ import { getOrCreateProvider } from '@/lib/db/factory';
 import { createErrorResponse } from '@/lib/api/errors';
 import { resolveConnection } from '@/lib/seed/resolve-connection';
 import { getSession } from '@/lib/auth';
-import { quoteIdentifier } from '@/lib/query-generators';
+import { quoteIdentifier, quoteQualifiedName } from '@/lib/query-generators';
 
 export async function POST(req: NextRequest) {
   try {
@@ -71,7 +71,7 @@ export async function POST(req: NextRequest) {
       }
 
       // Quote the table once for the target dialect (mixed-case / special names)
-      const safeTable = quoteIdentifier(tableName, capabilities);
+      const safeTable = quoteQualifiedName(tableName, capabilities);
 
       // Get total row count
       const countResult = await provider.query(`SELECT COUNT(*) as total FROM ${safeTable}`);

src/lib/query-generators.ts

@@ -35,6 +35,22 @@ export function quoteIdentifier(name: string, capabilities: ProviderCapabilities
   return /^[a-z_][a-z0-9_$]*$/.test(name) ? name : `"${name.replaceAll('"', '""')}"`;
 }
 
+/**
+ * Quote a possibly schema-qualified name (e.g. `employees.department`) by quoting
+ * each dotted segment independently. Quoting the whole string as one identifier
+ * (`"employees.department"`) would make the database look for a single relation
+ * literally named with a dot, which fails. Each segment is still quoted only when
+ * needed, so `employees.department` stays unquoted and `public.Order` becomes
+ * `public."Order"`.
+ */
+export function quoteQualifiedName(name: string, capabilities: ProviderCapabilities): string {
+  if (capabilities.queryLanguage === 'json') return name;
+  return name
+    .split('.')
+    .map((part) => quoteIdentifier(part, capabilities))
+    .join('.');
+}
+
 export function generateTableQuery(tableName: string, capabilities: ProviderCapabilities): string {
   if (capabilities.queryLanguage === 'json') {
     return JSON.stringify(
@@ -43,7 +59,7 @@ export function generateTableQuery(tableName: string, capabilities: ProviderCapa
       2
     );
   }
-  const table = quoteIdentifier(tableName, capabilities);
+  const table = quoteQualifiedName(tableName, capabilities);
   // Oracle
   if (capabilities.defaultPort === 1521) {
     return `SELECT * FROM ${table} FETCH FIRST 50 ROWS ONLY;`;
@@ -79,7 +95,7 @@ export function generateSelectQuery(
       2
     );
   }
-  const table = quoteIdentifier(tableName, capabilities);
+  const table = quoteQualifiedName(tableName, capabilities);
   const cols = columns.map((c) => `  ${quoteIdentifier(c.name, capabilities)}`).join(',\n') || '  *';
   // Oracle
   if (capabilities.defaultPort === 1521) {

tests/unit/lib/query-generators.test.ts

@@ -1,5 +1,5 @@
 import { describe, test, expect } from 'bun:test';
-import { generateTableQuery, generateSelectQuery, shouldRefreshSchema, quoteIdentifier } from '@/lib/query-generators';
+import { generateTableQuery, generateSelectQuery, shouldRefreshSchema, quoteIdentifier, quoteQualifiedName } from '@/lib/query-generators';
 import type { ProviderCapabilities } from '@/lib/db/types';
 import type { ColumnSchema } from '@/lib/types';
 
@@ -153,6 +153,24 @@ describe('quoteIdentifier', () => {
       .toBe('SELECT * FROM "Customer" LIMIT 50;');
   });
 
+  test('schema-qualified names are quoted per-segment, not as one identifier', () => {
+    // lowercase schema.table → no quotes (Postgres)
+    expect(quoteQualifiedName('employees.department', makeCaps({ defaultPort: 5432 })))
+      .toBe('employees.department');
+    // mixed-case table in a schema → only the table segment is quoted
+    expect(quoteQualifiedName('public.Order', makeCaps({ defaultPort: 5432 })))
+      .toBe('public."Order"');
+    // bare name (no dot) is unchanged
+    expect(quoteQualifiedName('Customer', makeCaps({ defaultPort: 5432 })))
+      .toBe('"Customer"');
+  });
+
+  test('generateTableQuery on a schema-qualified table does NOT wrap the dot (regression)', () => {
+    // Was producing the broken `"employees.department"`; must be `employees.department`.
+    expect(generateTableQuery('employees.department', makeCaps({ defaultPort: 5432 })))
+      .toBe('SELECT * FROM employees.department LIMIT 50;');
+  });
+
   test('generateSelectQuery quotes mixed-case table and columns (Postgres)', () => {
     const cols: ColumnSchema[] = [
       { name: 'Id', type: 'integer', nullable: false, isPrimary: true },