fix: address Copilot PR review (cross-route nav anchors, test isolation, doc accuracy)

- Header + Footer in-page nav anchors were hash-only (#features), which
  scroll to nothing when rendered on /deploy and other sub-pages. Changed to
  /#... so they navigate back to the homepage sections from any route.
- github-stars.test.ts assigned globalThis.fetch directly; mock.restore()
  doesn't revert that. Capture and restore the original fetch in afterEach.
- Corrected getStars JSDoc: it's build-time only (sets a User-Agent header
  browsers forbid); the client refresh does its own header-free fetch.

Declined (verified non-issues): the querySelectorAll<HTMLElement> generics in
the deploy.astro client script — Astro transpiles <script> via esbuild, which
strips TS types; dist contains zero 'querySelectorAll<' and the build passes.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Author: cevheri

src/components/Footer.astro

@@ -6,9 +6,9 @@ const sections = [
     id: "product",
     title: "Product",
     links: [
-      { label: "Features", href: "#features" },
-      { label: "Databases", href: "#databases" },
-      { label: "Tech Stack", href: "#tech-stack" },
+      { label: "Features", href: "/#features" },
+      { label: "Databases", href: "/#databases" },
+      { label: "Tech Stack", href: "/#tech-stack" },
       { label: "Deploy", href: "/deploy" },
       { label: "Live Demo", href: "https://app.libredb.org", external: true },
     ],

src/components/Header.astro

@@ -13,10 +13,10 @@
 
       <!-- Desktop Navigation -->
       <div class="hidden md:flex items-center gap-8">
-        <a href="#features" class="text-slate-400 hover:text-white transition-colors text-sm font-medium">Features</a>
-        <a href="#databases" class="text-slate-400 hover:text-white transition-colors text-sm font-medium">Databases</a>
-        <a href="#tech-stack" class="text-slate-400 hover:text-white transition-colors text-sm font-medium">Tech Stack</a>
-        <a href="#get-started" class="text-slate-400 hover:text-white transition-colors text-sm font-medium">Get Started</a>
+        <a href="/#features" class="text-slate-400 hover:text-white transition-colors text-sm font-medium">Features</a>
+        <a href="/#databases" class="text-slate-400 hover:text-white transition-colors text-sm font-medium">Databases</a>
+        <a href="/#tech-stack" class="text-slate-400 hover:text-white transition-colors text-sm font-medium">Tech Stack</a>
+        <a href="/#get-started" class="text-slate-400 hover:text-white transition-colors text-sm font-medium">Get Started</a>
         <a href="/deploy" class="text-slate-400 hover:text-white transition-colors text-sm font-medium">Deploy</a>
       </div>
 

src/lib/github-stars.test.ts

@@ -2,8 +2,12 @@ import { test, expect, mock, afterEach } from 'bun:test';
 import { formatStars, getStars, FALLBACK_STARS } from './github-stars';
 import { starRepos } from '../data/deploy-targets';
 
+// Tests assign globalThis.fetch directly (not spyOn), which mock.restore()
+// does not revert — capture and restore the original to keep tests isolated.
+const originalFetch = globalThis.fetch;
 afterEach(() => {
   mock.restore();
+  globalThis.fetch = originalFetch;
 });
 
 test('formatStars renders compact counts', () => {

src/lib/github-stars.ts

@@ -28,8 +28,10 @@ export function formatStars(n: number): string {
 }
 
 /**
- * Fetch star counts for each repo. Runs at build time (Node) and is safe to
- * call from a browser too. Any failure falls back to FALLBACK_STARS (or 0).
+ * Fetch star counts for each repo. Build-time only (Node): it sets a
+ * `User-Agent` header, which browsers forbid — the client refresh script in
+ * deploy.astro does its own header-free fetch instead. Any failure falls back
+ * to FALLBACK_STARS (or 0).
  */
 export async function getStars(repos: string[]): Promise<Record<string, number>> {
   const entries = await Promise.all(