-
Notifications
You must be signed in to change notification settings - Fork 828
Add MPRIS support #1596
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
paulfariello
wants to merge
36
commits into
librespot-org:dev
Choose a base branch
from
paulfariello:mpris
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add MPRIS support #1596
Changes from all commits
Commits
Show all changes
36 commits
Select commit
Hold shift + click to select a range
861ef53
Allow cloning SPIRC
wisp3rwind a41e331
add release date to AudioItem
wisp3rwind 6df285e
add Spirc.seek_offset command
wisp3rwind cd3f3a3
add initial MPRIS support using zbus
wisp3rwind fd91138
feat(mpris): serve identity based on configured name
paulfariello 710826b
feat(mpris): Add set_volume handler
paulfariello 0f5a0a3
feat(mpris): Retry with pid specific name on NameTaken error
paulfariello 23e7635
feat(player): Send current state of player for all new player listeners
paulfariello e6da469
feat(mpris): Notify when volume changed
paulfariello ddb5f4b
fix(mpris): Remove done todo
paulfariello 5e6807c
fix(mpris): Remove duplicated and commented function
paulfariello 08fd96e
fix(mpris): Add comment concerning non-support of setting playback rate
paulfariello 6f12e88
feat(mpris): Store metadata unserialized
paulfariello 65cc265
feat(mpris): Add debug logging
paulfariello 2f73b03
feat(mpris): Send biggest art url
paulfariello e7f0c8b
feat(mpris): Update track id on EndOfTrack
paulfariello a8ffe20
feat(player): Add position update option
paulfariello bb6d4bf
feat(mpris): Get position from player and provide it to MPRIS
paulfariello 3a3ea76
feat(mpris): Check track_id when setting position
paulfariello 11519ed
chore(mpris): Remove useless comment
paulfariello e8601c9
feat(mpris): Add support for desktop entry
paulfariello 15bc920
feat(mpris): Return error when trying to play/pause in wrong context
paulfariello 15280de
feat(mpris): Signal when position changed
paulfariello 69112e3
chore(mpris): alias zbus::fdo::{Error, Result} for readability
paulfariello 9996b4c
feat(player): Allow for stopped event without track_id
paulfariello cc8302b
feat(player): Rename position update interval option
paulfariello 1c418ad
feat(mpris): Upgrade to zbus 5
paulfariello dfe09f0
feat(player): Add position_ms in Loading event
paulfariello fa4cc94
feat(changelog): Add mpris changelog
paulfariello c19f8b7
fixup! add initial MPRIS support using zbus
paulfariello 953fafc
feat(player): Replace position update interval option with sensible d…
paulfariello ce54cfa
fixup! feat(mpris): Check track_id when setting position
paulfariello ea324eb
fixup! add initial MPRIS support using zbus
paulfariello d6a83b7
fixup! feat(player): Allow for stopped event without track_id
paulfariello a021864
fixup! feat(mpris): Store metadata unserialized
paulfariello 46755ec
fixup! feat(mpris): Store metadata unserialized
paulfariello File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please tag in the changelog that this is a breaking change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done