Commit 18f0166
committed
menu_setting: stop clobbering SD_FREE_FLAG_MAIN_MENU_GROUP in setting_group_setting
setting_group_setting() sets SD_FREE_FLAG_MAIN_MENU_GROUP on top-level
ST_GROUP settings whose parent is the main menu, but a leftover blanket
"result.free_flags = 0;" a few lines below the OR-assignment wiped the
bit back out on every group. result is already zero-initialised via
"result = {0}", so the reset was redundant as well as destructive.
With the flag never surviving, menu_cbs_title.c did not bind
action_get_title_group_settings for the main-menu/tab entries, so their
titles fell through to action_get_title_default ("Select File") on XMB,
GLUI and Ozone. The same flag gates menu_cbs_left.c / menu_cbs_right.c,
so left/right handling on those entries was silently affected too.
Fixes #19180.1 parent 658f82e commit 18f0166
1 file changed
Lines changed: 4 additions & 2 deletions
File tree
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1451 | 1451 | | |
1452 | 1452 | | |
1453 | 1453 | | |
1454 | | - | |
1455 | | - | |
| 1454 | + | |
| 1455 | + | |
| 1456 | + | |
| 1457 | + | |
1456 | 1458 | | |
1457 | 1459 | | |
1458 | 1460 | | |
| |||
0 commit comments