make assets update optional on first run and enable by default for webOS

Author: cscd98

file_path_special.h

@@ -126,6 +126,10 @@ RETRO_BEGIN_DECLS
 #define FILE_PATH_CORE_INFO_CACHE "core_info.cache"
 #define FILE_PATH_CORE_INFO_CACHE_REFRESH "core_info.refresh"
 
+/* sizes of zip plus decompression space required rounded up to nearest 50MB */
+#define ASSETS_ZIP_PLUS_DECOMPRESSION_SIZE 209715200 /* 200MB */
+#define DATABASE_RDB_ZIP_PLUS_DECOMPRESSION_SIZE 262144000 /* 250MB */
+
 #ifdef HAVE_LAKKA
  #ifdef HAVE_LAKKA_SERVER
   #define FILE_PATH_LAKKA_URL HAVE_LAKKA_SERVER

libretro-common/file/file_path_io.c

@@ -37,10 +37,15 @@
 
 #ifdef _WIN32
 #include <direct.h>
+#include <windows.h>
 #else
 #include <unistd.h> /* stat() is defined here */
 #endif
 
+#if defined(__unix__) || defined(__APPLE__)
+#include <sys/statvfs.h>
+#endif
+
 /* TODO/FIXME - globals */
 static retro_vfs_stat_t path_stat_cb   = retro_vfs_stat_impl;
 static retro_vfs_mkdir_t path_mkdir_cb = retro_vfs_mkdir_impl;
@@ -78,6 +83,33 @@ bool path_is_directory(const char *path)
    return (path_stat_cb(path, NULL) & RETRO_VFS_STAT_IS_DIRECTORY) != 0;
 }
 
+bool path_is_empty_directory(const char *dir)
+{
+    struct retro_vfs_dir_handle *d;
+    const char *name;
+
+    d = retro_vfs_opendir_impl(dir, false);
+    if (!d)
+        return false;
+
+    while (retro_vfs_readdir_impl(d))
+    {
+        name = retro_vfs_dirent_get_name_impl(d);
+
+        /* Skip . and .. */
+        if (name &&
+            strcmp(name, ".") != 0 &&
+            strcmp(name, "..") != 0)
+        {
+            retro_vfs_closedir_impl(d);
+            return false;
+        }
+    }
+
+    retro_vfs_closedir_impl(d);
+    return true;
+}
+
 bool path_is_character_special(const char *path)
 {
    return (path_stat_cb(path, NULL) & RETRO_VFS_STAT_IS_CHARACTER_SPECIAL) != 0;
@@ -146,3 +178,21 @@ bool path_mkdir(const char *dir)
    }
    return false;
 }
+
+int64_t path_get_free_space(const char *path)
+{
+#if defined(_WIN32)
+   ULARGE_INTEGER free_bytes_available;
+   if (GetDiskFreeSpaceExA(path, &free_bytes_available, NULL, NULL))
+      return (int64_t)free_bytes_available.QuadPart;
+   return -1;
+#elif defined(__unix__) || defined(__APPLE__)
+   struct statvfs fs;
+   if (statvfs(path, &fs) == 0)
+      return (int64_t)fs.f_bavail * (int64_t)fs.f_frsize;
+   return -1;
+#else
+   /* Unsupported platform */
+   return -1;
+#endif
+}

libretro-common/include/file/file_path.h

@@ -668,6 +668,10 @@ bool path_mkdir(const char *dir);
  */
 bool path_is_directory(const char *path);
 
+bool path_is_empty_directory(const char *dir);
+
+int64_t path_get_free_space(const char *path);
+
 /* Time format strings with AM-PM designation require special
  * handling due to platform dependence
  * @return Length of the string written to @s

menu/menu_driver.c

@@ -49,6 +49,7 @@
 #include "menu_driver.h"
 #include "menu_cbs.h"
 #include "../driver.h"
+#include "../file_path_special.h"
 #include "../list_special.h"
 #include "../msg_hash_lbl_str.h"
 #include "../paths.h"
@@ -3724,13 +3725,15 @@ static bool rarch_menu_init(
 #endif
 
 #ifdef HAVE_COMPRESSION
+   bool have_bundled_assets = false;
    if (      settings->bools.bundle_assets_extract_enable
          && !string_is_empty(settings->paths.bundle_assets_src)
          && !string_is_empty(settings->paths.bundle_assets_dst)
          && (settings->uints.bundle_assets_extract_version_current
             != settings->uints.bundle_assets_extract_last_version)
       )
    {
+      have_bundled_assets = true;
       p_dialog->current_type         = MENU_DIALOG_HELP_EXTRACT;
       task_push_decompress(
             settings->paths.bundle_assets_src,
@@ -3750,22 +3753,37 @@ static bool rarch_menu_init(
 #if defined(HAVE_ONLINE_UPDATER) && defined(HAVE_NETWORKING) && defined(HAVE_ZLIB)
    else
    {
+#ifdef HAVE_CONFIGFILE
+   if (!menu_show_start_screen)
+      return true;
+#endif
+#ifdef HAVE_COMPRESSION
+   if (have_bundled_assets)
+      return true;
+#endif
+
 #ifdef HAVE_UPDATE_ASSETS
-      if (!path_is_directory(settings->paths.directory_assets))
-         menu_download(MENU_ENUM_LABEL_CB_UPDATE_ASSETS);
+      if (!path_is_directory(settings->paths.directory_assets) || path_is_empty_directory(settings->paths.directory_assets))
+      {
+         if (path_get_free_space(settings->paths.directory_assets) >= ASSETS_ZIP_PLUS_DECOMPRESSION_SIZE)
+            menu_download(MENU_ENUM_LABEL_CB_UPDATE_ASSETS);
+      }
 #endif
-      if (!path_is_directory(settings->paths.directory_autoconfig))
+      if (!path_is_directory(settings->paths.directory_autoconfig) || path_is_empty_directory(settings->paths.directory_autoconfig))
          menu_download(MENU_ENUM_LABEL_CB_UPDATE_AUTOCONFIG_PROFILES);
 #ifdef HAVE_UPDATE_CORE_INFO
-      if (!path_is_directory(settings->paths.path_libretro_info))
+      if (!path_is_directory(settings->paths.path_libretro_info) || path_is_empty_directory(settings->paths.path_libretro_info))
          menu_download(MENU_ENUM_LABEL_CB_UPDATE_CORE_INFO_FILES);
 #endif
-#ifdef HAVE_LIBRETRODB
-      if (!path_is_directory(settings->paths.path_content_database))
-         menu_download(MENU_ENUM_LABEL_CB_UPDATE_DATABASES);
+#if defined(HAVE_LIBRETRODB)
+      if (!path_is_directory(settings->paths.path_content_database) || path_is_empty_directory(settings->paths.path_content_database))
+      {
+         if (path_get_free_space(settings->paths.path_content_database) >= DATABASE_RDB_ZIP_PLUS_DECOMPRESSION_SIZE)
+            menu_download(MENU_ENUM_LABEL_CB_UPDATE_DATABASES);
+      }
 #endif
 #if defined(RARCH_MOBILE) && defined(HAVE_OVERLAY)
-      if (!path_is_directory(settings->paths.directory_overlay))
+      if (!path_is_directory(settings->paths.directory_overlay) || path_is_empty_directory(settings->paths.directory_overlay))
          menu_download(MENU_ENUM_LABEL_CB_UPDATE_OVERLAYS);
 #endif
    }