Skip to content

Profiles#19067

Open
fpscan wants to merge 6 commits into
libretro:masterfrom
fpscan:feature-profiles
Open

Profiles#19067
fpscan wants to merge 6 commits into
libretro:masterfrom
fpscan:feature-profiles

Conversation

@fpscan

@fpscan fpscan commented May 26, 2026

Copy link
Copy Markdown
Contributor
image image image image

Guidelines

  1. Rebase before opening a pull request
  2. If you are sending several unrelated fixes or features, use a branch and a separate pull request for each
  3. If possible try squashing everything in a single commit. This is particularly beneficial in the case of feature merges since it allows easy bisecting when a problem arises
  4. RetroArch codebase follows C89 coding rules for portability across many old platforms check using C89_BUILD=1

Description

[Description of the pull request, detail any issues you are fixing or any features you are implementing]

Related Issues

[Any issues this pull request may be addressing]

Related Pull Requests

[Any other PRs from related repositories that might be needed for this pull request to work]

Reviewers

[If possible @mention all the people that should review your pull request]

@hizzlekizzle

hizzlekizzle commented May 26, 2026

Copy link
Copy Markdown
Collaborator

This is a very common request among handheld users. @sonninnos

EDIT: @fpscan looks like you have some C89 compliance errors:

profile_manager.c:310:4: error: ISO C90 forbids mixed declarations and code [-Werror=declaration-after-statement]
  310 |    int idx = g_profile_list.active_index;
      |    ^~~
profile_manager.c: In function ‘profile_manager_create’:
profile_manager.c:346:4: error: ISO C90 forbids mixed declarations and code [-Werror=declaration-after-statement]
  346 |    char sanitized[128];
      |    ^~~~
profile_manager.c: In function ‘profile_manager_save_current’:
profile_manager.c:424:4: error: ISO C90 forbids mixed declarations and code [-Werror=declaration-after-statement]
  424 |    char dst_path[PATH_MAX_LENGTH];
      |    ^~~~
profile_manager.c: In function ‘profile_manager_delete’:
profile_manager.c:453:4: error: ISO C90 forbids mixed declarations and code [-Werror=declaration-after-statement]
  453 |    int i;
      |    ^~~

@gouchi

gouchi commented Jun 10, 2026

Copy link
Copy Markdown
Member

This feature is in Settings tab > User > Profiles

image

@gouchi

gouchi commented Jun 11, 2026

Copy link
Copy Markdown
Member

Fix #4749 at least for configuration settings.

@fpscan

fpscan commented Jul 2, 2026

Copy link
Copy Markdown
Contributor Author

@gouchi
image

@fpscan fpscan force-pushed the feature-profiles branch from 5563918 to 83cc8c4 Compare July 2, 2026 16:54
@fpscan fpscan force-pushed the feature-profiles branch from 83cc8c4 to 772f649 Compare July 3, 2026 15:44
- Revert ozone.c non-profile changes back to upstream:
  - Restore OSK backdrop color (0.15 alpha, not 0.00)
  - Restore list_size guard for single-line OSK input
  - Restore text position formatting (multi-line style)
  - Restore cursor type (int, not unsigned) and -2 offset
  - Restore y_offset calculation (line_height*2, not 25px)
  - Restore messagebox comment case (Find, not find)
  - Remove stray blend_begin before messagebox box draw
  - Restore video_width/height in messagebox draw calls
  - Restore pure_white[16] init loop count (16, not 15)
  - Restore footer icon alpha (col 0.5, not entries_icon 1.0)
  - Restore messagebox animate if/else block
  - Restore else-if (*menu_state_msg) guard
  - Restore footer_margin=40 and icon_size=35 in tap_footer
- Restore retroarch.c CMD_EVENT_CLOSE_CONTENT to upstream logic
  (flags set unconditionally, HAVE_GFX_WIDGETS block restored)
- Restore refresh rate restore to correct position in main_quit
- Remove ellipsis from Create Profile and Save to New Profile labels
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants