rgui: add 1:1 (square) menu aspect ratio for square displays#19170
Open
GavriloviciEduard wants to merge 1 commit into
Open
rgui: add 1:1 (square) menu aspect ratio for square displays#19170GavriloviciEduard wants to merge 1 commit into
GavriloviciEduard wants to merge 1 commit into
Conversation
Existing menu aspect ratios either letterbox (wasted space) or stretch (distortion) on square displays such as 720x720 handhelds. Add a native 1:1 option that renders a square framebuffer and integer-scales cleanly to fill the panel. Appended after AUTO, so existing configs are unaffected.
|
I did this also for a test a while ago for my RGB30, I ended up not using it however. My old patch also edits these files, I remember that something was off without adding a Did you look into these? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Existing
rguimenu aspect ratios either letterbox (wasted screen) or stretch (distortion) on square displays such as 720×720 handhelds (e.g. the Anbernic RG Rotate). This adds a native 1:1 option to the menu aspect ratio setting that renders a square framebuffer and integer-scales cleanly to fill the panel (240×240 → 3× → 720×720).The new value is appended after
AUTOinenum rgui_aspect_ratio, so it takes the next free index and existing configs / savedrgui_aspect_ratiovalues are unaffected. The setting range auto-extends viaRGUI_ASPECT_RATIO_LAST - 1, so no range edit is needed.Testing: builds clean on desktop and on-device (arm64 Android debug build). Verified on a 720×720 panel, screenshots below (4:3 letterboxed vs 4:3 stretched vs 1:1).