Enables MSys2 MSYS environment to build SDL3#15514
Open
stahta01 wants to merge 6 commits intolibsdl-org:mainfrom
Open
Enables MSys2 MSYS environment to build SDL3#15514stahta01 wants to merge 6 commits intolibsdl-org:mainfrom
stahta01 wants to merge 6 commits intolibsdl-org:mainfrom
Conversation
sezero
reviewed
May 5, 2026
sezero
reviewed
May 5, 2026
sezero
reviewed
May 5, 2026
sezero
reviewed
May 5, 2026
sezero
reviewed
May 5, 2026
sezero
reviewed
May 5, 2026
sezero
reviewed
May 5, 2026
sezero
reviewed
May 5, 2026
sezero
reviewed
May 5, 2026
sezero
reviewed
May 5, 2026
Author
|
I decided that most of your rejections can be reduced down to using So, I am doing those changes and others you posted. Tim S. |
stahta01
force-pushed
the
msys_main_CI
branch
7 times, most recently
from
f73c392 to
76fec34
Compare
Author
|
Doing many casts in C programming when it is not needed can be a way to hiding programming mistakes after future changes. And if is cleaner to use defines like I have is the correct thing to do! When I was asked to revert my changes in "SDL3/SDL_stdinc.h" and use casts instead I considered that to be a major programming ethical violation! So, either understand or get someone else to either approved or reject this PR. Because I also am finished with it. |
Co-authored-by: TrueCat17 <truecat17@gmail.com>
under Cygwin or MSYS build enviroments
Many ideas are likely from PR 15457 Co-authored-by: TrueCat17 <truecat17@gmail.com> Co-authored-by: Anonymous Maarten <anonymous.maarten@gmail.com> Co-authored-by: Ozkan Sezer <sezeroz@gmail.com>
Co-authored-by: Anonymous Maarten <madebr@users.noreply.github.com> [sdl-ci-filter msys2-msys]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains code from PR fix building on CYGWIN #15457
Description
This PR is based on the PR #15457.
The major difference is the PR enable MSYS to build SDL3.
The warning reduction changes are very different in header "SDL_platform_defines.h".
The method to get "d3d12.h" to work is very different.
This PR adds msys CI support and the tests runs; but about 5 tests fail.
Existing Issue(s)