Skip to content

emscripten: don't dispatch user input to hidden windows #15522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
slouken merged 1 commit into from
May 20, 2026
Merged

emscripten: don't dispatch user input to hidden windows #15522

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions src/video/emscripten/SDL_emscriptenevents.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -713,6 +713,15 @@ static void Emscripten_UpdateMouseFromEvent(SDL_WindowData *window_data, const E
{
SDL_assert(event->pointer_type == PTRTYPE_MOUSE);

// Hidden windows (e.g. a shared GL-context window) may share the DOM canvas with the
// visible window. Their pointer-event listeners would otherwise fire alongside the
// visible window's, fighting over `mouse->focus` and producing events tagged with the
// hidden window's ID -- causing downstream consumers that key by window ID to silently
// drop them. Hidden windows shouldn't take part in user-input dispatch.
if (window_data->window->flags & SDL_WINDOW_HIDDEN) {
return;
}

// rescale (in case canvas is being scaled)
double client_w, client_h;
emscripten_get_element_css_size(window_data->canvas_id, &client_w, &client_h);
Expand Down Expand Up @@ -838,6 +847,11 @@ static void Emscripten_HandleMouseFocus(SDL_WindowData *window_data, const Emscr
{
SDL_assert(event->pointer_type == PTRTYPE_MOUSE);

// Hidden windows shouldn't ever become the mouse-focus target.
if (window_data->window->flags & SDL_WINDOW_HIDDEN) {
return;
}

const bool isPointerLocked = window_data->has_pointer_lock;

if (!isPointerLocked) {
Expand Down
Loading