Skip to content

Properly fix cursor position in Korean IME#15648

Merged
slouken merged 1 commit into
libsdl-org:mainfrom
Susko3:fix-windows-korean-ime-v2
May 18, 2026
Merged

Properly fix cursor position in Korean IME#15648
slouken merged 1 commit into
libsdl-org:mainfrom
Susko3:fix-windows-korean-ime-v2

Conversation

@Susko3
Copy link
Copy Markdown
Contributor

@Susko3 Susko3 commented May 18, 2026

  • I confirm that I am the author of this code and release it to the SDL project under the Zlib license. This contribution does not contain code from other sources, including code generated by a Large Language Model ("AI").

Description

If an IME doesn't provide a cursor position via GCS_CURSORPOS, the cursor position will now default to the end of the composition. This is what other programs on Windows do for Korean IME. (Sidenote: we could theoretically report the position as not set, as allowed by https://wiki.libsdl.org/SDL3/SDL_TextEditingEvent, but that can be done in another PR).

Existing Issue(s)

@slouken slouken merged commit b608108 into libsdl-org:main May 18, 2026
47 checks passed
@slouken slouken added this to the 3.4.10 milestone May 18, 2026
@slouken
Copy link
Copy Markdown
Collaborator

slouken commented May 18, 2026

This looks good. Merged, thanks!

@Susko3 Susko3 deleted the fix-windows-korean-ime-v2 branch May 18, 2026 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SDL_EVENT_TEXT_EDITING selection position is incorrectly reported for Microsoft Korean IME

2 participants