GPU: Query API#15651
Draft
thatcosmonaut wants to merge 4 commits into
Draft
Conversation
Collaborator
Author
|
I'm considering that it might be nice to allow query pools to cycle, since otherwise users will have to maintain their own query pool ring buffers. |
kg
reviewed
May 19, 2026
Comment on lines
+4080
to
+4081
| * After this function is called, the data in the query pool is no longer valid, | ||
| * so don't call this function multiple times before performing another query. |
Contributor
There was a problem hiding this comment.
Does this discard the entire contents of the query pool or just the data for [first_query, first_query + count]? It reads like the former
Collaborator
Author
There was a problem hiding this comment.
That comment is actually wrong, I need to add an explicit reset function because Vulkan requires it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Provides an API for performing timestamp and occlusion queries. Implemented in Vulkan as a proof of concept.
Before merge:
Existing Issue(s)
Implements #11696