SDL2 thread proxying fixes#5365
Conversation
This PR uses new APIs added in [emscripten-core/emscripten#9336](emscripten-core/emscripten#9336) to improve compatibility with USE_PTHREADS=1. Original PR: emscripten-ports/SDL2#127 By: @jakogut Reviewed by: Daft-Freak
|
I think some of the comments from the original PR still apply, though I still haven't really looked into emscripten's threading stuff... |
Daft-Freak
left a comment
There was a problem hiding this comment.
Minor cast warning and formatting comments. Also SDL_GetDisplayUsableBounds has some more EM_ASMs that were added after the original PR.
Co-authored-by: Charlie Birks <charlie@daftgames.net>
|
I hope I addressed the required changes. Can't follow about |
|
Yeah you should update |
|
@Daft-Freak Do we want to merge this and deal with SDL_GetDisplayUsableBounds separately, or should one of us add it to this PR? |
|
It's probably just |
|
I added the SDL_GetDisplayDisplayBounds stuff in ea7d530, so this is good to go now. |
|
thanks a lot @icculus 🙇♂️ |
Description
This PR uses new APIs added in emscripten-core/emscripten#9336 to improve compatibility with USE_PTHREADS=1.
Original PR: emscripten-ports/SDL2#127
By: @jakogut
Reviewed by: @Daft-Freak
This fix enables me to compile an executable using
-s USE_PTHREADS=1 -s USE_SDL=2and not get the following error in the chromuim debug consoleWith the current patch applied the InfiniSim Simulator works 🎉
Existing Issue(s)