emscripten: fix undefined symbol errors in non-threaded builds#5773
Merged
slouken merged 2 commits intolibsdl-org:mainfrom Jun 8, 2022
Merged
emscripten: fix undefined symbol errors in non-threaded builds#5773slouken merged 2 commits intolibsdl-org:mainfrom
slouken merged 2 commits intolibsdl-org:mainfrom
Conversation
This is how everything else was handled and fixes undefined symbol errors in non-threads builds.
Contributor
|
Can you remove this line so we test building an application on ci? SDL/.github/workflows/emscripten.yml Line 25 in b9c2ad8 |
Wohlstand
added a commit
to WohlSoft/AudioCodecs
that referenced
this pull request
Jun 8, 2022
ras0219-msft
pushed a commit
to microsoft/vcpkg
that referenced
this pull request
Aug 3, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Changes the framebuffer/cursor proxying code to use
MAIN_THREAD_EM_ASMinstead ofemscripten_sync_run_in_main_runtime_threadwith a function wrapping theEM_ASM. This is how everything else was handled.Fixes this error
error: undefined symbol: emscripten_sync_run_in_main_runtime_thread_caused by the proxying changes (caught while trying to update Emscripten to the latest release(emscripten-core/emscripten#16916)).