unix: Make network monitoring optional in getifaddrs() impl#164
Merged
Conversation
While getifaddrs() is POSIX and its usage can be enabled on more platforms than the current set, network monitoring APIs are platform-specific. Hence make the network monitoring optional, enabling it when either Netlink (Linux) or PF_ROUTE sockets (BSDs) is available. This gives to any other getifaddrs() platform a functional SDL_net, simply without updates to the available network interfaces after the first listing.
Collaborator
|
This is a good idea. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While
getifaddrs()is POSIX and its usage can be enabled on more platforms than the current set, network monitoring APIs are platform-specific.Hence make the network monitoring optional, enabling it when either Netlink (Linux) or
PF_ROUTEsockets (BSDs) is available. This gives to any othergetifaddrs()platform a functional SDL_net, simply without updates to the available network interfaces after the first listing.