Use the correct error types

Author: Joseph-Edwards

src/action.cpp

@@ -147,7 +147,7 @@ Increase the capacity to a value that is greater or equal to *val*.
 :param val: new capacity of an action instance.
 :type val: int
 
-:raises ValueError:  if ``val`` is too large.
+:raises MemoryError:  if ``val`` is too large.
 
 :complexity:
   At most linear in the :any:`size()` of the :py:class:`Action`.

src/adapters.cpp

@@ -102,7 +102,7 @@ This call operator returns the image of *pt* acted on by *x*.
 :rtype: Point
 
 :raises TypeError:
-    If the wrapped C++ type of the sample objects passed via *element* and
+    If the wrapped C++ type of the sample objects passed via *x* and
     *point* are not the same as the wrapped types of the arguments in any
     invocation of the call operator. For example, if *point* is ``PPerm([], [],
     256)``, then the underlying C++ type uses 8-bit integers to store image
@@ -171,7 +171,7 @@ This call operator returns the image of *pt* acted on by *x*.
 :rtype: Point
 
 :raises TypeError:
-    If the wrapped C++ type of the sample objects passed via *element* and
+    If the wrapped C++ type of the sample objects passed via *x* and
     *point* are not the same as the wrapped types of the arguments in any
     invocation of the call operator. For example, if *point* is ``PPerm([], [],
     256)``, then the underlying C++ type uses 8-bit integers to store image

src/froidure-pin.cpp

@@ -132,6 +132,10 @@ Copy a :any:`FroidurePin` object.
 :returns: A copy.
 :rtype: FroidurePin
 )pbdoc");
+      // This function should really throw a ValueError if the degree of x is
+      // incompatible with the existing degree, but this doesn't get detected at
+      // the Python level, so a LibsemigroupsError is thrown instead. It would
+      // be possible to intercept this, but it probably isn't worth the effort.
       thing.def("add_generator",
                 &FroidurePin_::add_generator,
                 py::arg("x"),
@@ -166,7 +170,7 @@ elements than before (whether it is fully enumerating or not).
 :returns: ``self``.
 :rtype: FroidurePin
 
-:raises ValueError:
+:raises LibsemigroupsError:
    if the degree of *x* is incompatible with the existing degree (if any).
 
 :raises TypeError:
@@ -199,7 +203,7 @@ See :any:`add_generator` for a detailed description.
 :raises TypeError:
    if any item in *gens* is not of the same type as the existing generators (if any).
 
-:raises ValueError:
+:raises LibsemigroupsError:
    if the degree of any item in *gens* is incompatible with the existing degree (if any).
 )pbdoc");
 

src/libsemigroups_pybind11/action.py

@@ -207,7 +207,7 @@ def __init__(self: _Self, *args, generators=None, seeds=None, func=None, side=No
         if _to_cxx(self) is not None:
             return
         if len(args) != 0:
-            raise ValueError(f"expected 0 positional arguments, but found {len(args)}")
+            raise TypeError(f"expected 0 positional arguments, but found {len(args)}")
         if not isinstance(generators, list):
             raise TypeError(
                 "expected the keyword argument 'generators' to be "

src/libsemigroups_pybind11/adapters.py

@@ -68,9 +68,7 @@ def __init__(self: _Self, *args, point=None, element=None) -> None:
         if _to_cxx(self) is not None:
             return
         if len(args) != 0:
-            raise ValueError(
-                f"expected 0 positional arguments, but found {len(args)}"
-            )
+            raise TypeError(f"expected 0 positional arguments, but found {len(args)}")
         self.py_template_params = (
             type(_to_cxx(element)),
             type(_to_cxx(point)),

src/libsemigroups_pybind11/detail/cxx_wrapper.py

@@ -81,13 +81,13 @@ def __init__(
 
         for kwarg in required_kwargs:
             if kwarg not in kwargs:
-                raise ValueError(
+                raise TypeError(
                     f'required keyword argument "{kwarg}" not found, '
                     f"found {tuple(kwargs.keys())} instead"
                 )
         for kwarg in kwargs:
             if kwarg not in required_kwargs and kwarg not in optional_kwargs:
-                raise ValueError(
+                raise TypeError(
                     f'unexpected keyword argument "{kwarg}", '
                     f"required keyword arguments are {required_kwargs} "
                     f"and optional keyword arguments are {optional_kwargs}"

src/libsemigroups_pybind11/froidure_pin.py

@@ -162,7 +162,7 @@ def __init__(self: _Self, *args) -> None:
         if _to_cxx(self) is not None:
             return
         if len(args) == 0:
-            raise ValueError("expected at least 1 argument, found 0")
+            raise TypeError("expected at least 1 argument, found 0")
 
         if isinstance(args[0], list) and len(args) == 1:
             gens = args[0]

src/libsemigroups_pybind11/konieczny.py

@@ -130,7 +130,7 @@ def __init__(self: Self, *args) -> None:
         if _to_cxx(self) is not None:
             return
         if len(args) == 0:
-            raise ValueError("expected at least 1 argument, found 0")
+            raise TypeError("expected at least 1 argument, found 0")
 
         if isinstance(args[0], list) and len(args) == 1:
             gens = args[0]

src/libsemigroups_pybind11/presentation/__init__.py

@@ -104,7 +104,7 @@ def __init__(self: Self, *args, **kwargs) -> None:
             or (len(args) == 1 and len(kwargs) > 0)
             or len(args) > 1
         ):
-            raise ValueError(
+            raise TypeError(
                 'expected 1 positional argument or the keyword argument "Word"'
                 f" but found {len(args)} positional arguments, and keywords arguments "
                 f"{tuple(kwargs.keys())}"
@@ -124,7 +124,7 @@ def __init__(self: Self, *args, **kwargs) -> None:
                     f"but found {type(args[0])}"
                 )
             if isinstance(args[0], list) and not all(isinstance(x, int) for x in args[0]):
-                raise ValueError("expected the argument to consist of int values")
+                raise TypeError("expected the argument to consist of int values")
             if isinstance(args[0], str):
                 self.py_template_params = (str,)
             if isinstance(args[0], list):

src/libsemigroups_pybind11/schreier_sims.py

@@ -71,7 +71,7 @@ def __init__(self: _Self, *args) -> None:
         if _to_cxx(self) is not None:
             return
         if len(args) == 0:
-            raise ValueError("expected at least 1 argument, found 0")
+            raise TypeError("expected at least 1 argument, found 0")
 
         if isinstance(args[0], list) and len(args) == 1:
             gens = args[0]