Resolve warnings in headers

Author: HexDecimal

src/bas_entity.hpp

@@ -32,16 +32,17 @@ public :
 		NORTH, SOUTH, EAST, WEST,
 		NE, NW, SE, SW };
 
-	float x,y;
+	float x{0};
+	float y{0};
 
-	Entity() : x(0),y(0) {}
-	Entity(int px,int py) : x(px),y(py) {}
-	Entity(float px,float py) : x(px),y(py) {}
+	Entity() = default;
+	Entity(int px,int py) : x{static_cast<float>(px)},y{static_cast<float>(py)} {}
+	Entity(float px,float py) : x{px},y{py} {}
 	// get subcell coordinates
 	int getSubX() const { return (int)(x*2); }
 	int getSubY() const { return (int)(y*2); }
-	void setPos(int x, int y) { this->x=x; this->y=y; }
-	void setPos(float x, float y) { this->x=x; this->y=y; }
+	void setPos(int new_x, int new_y) { x=new_x; y=new_y; }
+	void setPos(float new_x, float new_y) { x=new_x; y=new_y; }
 	Entity &addDir(Direction d) {
 		static int xdirs[11] = { 0, 0, 0, 0, 0, 1, -1, 1, -1, 1, -1};
 		static int ydirs[11] = { 0, 0, 0, -1, 1, 0, 0, -1, -1, 1, 1};

src/mob_creature.hpp

@@ -90,7 +90,7 @@ public :
 	inline int getChar() const { return ch; }
 	inline int getAttackDamages() const { return (int)attackDamages; }
 	inline const Light *getLight() const { return light; }
-	inline void setLight(Light *light) { this->light=light; }
+	inline void setLight(Light *light_ptr) { light=light_ptr; }
 	// resources
 	inline void setLife(float value) { maxStatusResource[StatusResource::LIFE] = value; }
 	inline void setMana(float value) { maxStatusResource[StatusResource::MANA] = value; }

src/mob_player.hpp

@@ -38,7 +38,7 @@ public :
 	void termLevel();
 	void render(LightMap *lightMap);
 	void setLightRange(float range) { light->range=range; }
-	void setLightColor(TCODColor col) { light->color=col; }
+	void setLightColor(TCODColor new_color) { light->color=new_color; }
 	static bool getMoveKey(TCOD_key_t key,bool *up, bool *down, bool *left, bool *right);
 	inline float getAverageSpeed() { return averageSpeed;}
 	void computeStealth(float elapsed);

src/ui_dialog.hpp

@@ -42,14 +42,17 @@ class UIListener;
 
 class Widget {
 public :
-	Widget() : x(0),y(0),w(0),h(0) {}
-	Widget(int x, int y) : x(x),y(y) {}
-	Widget(int x, int y, int w, int h) : x(x),y(y),w(w),h(h) {}
-	void setPos(int x, int y) { this->x=x;this->y=y;}
-	void setSize(int w, int h) { this->w=w;this->h=h;}
+	Widget() = default;
+	Widget(int x, int y) : x{x},y{y} {}
+	Widget(int x, int y, int w, int h) : x{x},y{y},w{w},h{h} {}
+	void setPos(int new_x, int new_y) { x=new_x;y=new_y;}
+	void setSize(int new_w, int new_h) { w=new_w;h=new_h;}
 	void addListener(UIListener *listener) { listeners.push(listener); }
 	void removeListener(UIListener *listener) { listeners.removeFast(listener); }
-	int x,y,w,h;
+	int x{0};
+	int y{0};
+	int w{0};
+	int h{0};
 protected :
 	TCODList<UIListener *> listeners;
 	void sendEvent(EWidgetEvent event);
@@ -123,8 +126,8 @@ protected :
 class Dialog : public UmbraWidget {
 public :
 	Dialog() : flags(0),isMinimized(false),waitRelease(false) {}
-	void keyboard (TCOD_key_t &key) { this->key=key; UmbraWidget::keyboard(key); }
-	void mouse (TCOD_mouse_t &ms) { this->ms=ms; UmbraWidget::mouse(ms); }
+	void keyboard (TCOD_key_t &key_event) { this->key=key_event; UmbraWidget::keyboard(key_event); }
+	void mouse (TCOD_mouse_t &ms_event) { this->ms=ms_event; UmbraWidget::mouse(ms); }
 	bool update (void);
 	virtual bool update(float elapsed, TCOD_key_t &k, TCOD_mouse_t &mouse) = 0;
 	void setMaximized();

src/util_textgen.hpp

@@ -98,7 +98,7 @@ protected :
 class RandomNameFunc : public ITextGeneratorFunc {
 public :
 	RandomNameFunc(TCODRandom *rnRng) : rnRng(rnRng) {}
-	const char * execute(const char *params) {
+	const char * execute([[maybe_unused]] const char *params) {
 		return NameGenerator::generateRandomName(rnRng);
 	}
 protected :