Skip to content

Change version numbers before 2.0 release#472

Open
nijtmans wants to merge 1 commit into
developfrom
ver-2.0-update
Open

Change version numbers before 2.0 release#472
nijtmans wants to merge 1 commit into
developfrom
ver-2.0-update

Conversation

@nijtmans

@nijtmans nijtmans commented Dec 5, 2019

Copy link
Copy Markdown
Collaborator

The (microsoft) convension for dll's doesn't start with "lib" as on UNIX. So I suggest to use "tommath2.dll" as dll name. Also I made the other necessary corresponding makefile-related changes for the major upgrade.

@minad

minad commented Dec 5, 2019

Copy link
Copy Markdown
Member

The "big change" here is the name change of the dll. I am not sure if we want to include the version number in the name. This is the job of a distribution or package builder I think. @sjaeckel will take care of the other changes regarding the version numbers.

@nijtmans

nijtmans commented Dec 5, 2019

Copy link
Copy Markdown
Collaborator Author

On other platforms than Windows - indeed - it is not customary to have a version number in the library name. On Windows it's normal (examples: ws2_32.dll, zlib1.dll, winsqlite3.dll, tcl86.dll, msvcr100.dll ...). Windows dll's simply don't have a suitable mechanism as other platforms do.

Comment thread makefile.mingw
@nijtmans

Copy link
Copy Markdown
Collaborator Author

ping?

@czurnieden czurnieden left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you do us a favor and rebase on develop, if you don't mind? Thank you!

@sjaeckel

Copy link
Copy Markdown
Member

This will only be merged right before the 2.0.0 release, so there's no need to rebase now.

@sjaeckel sjaeckel added this to the v2.0.0 milestone Mar 10, 2020
@czurnieden

Copy link
Copy Markdown
Contributor

This will only be merged right before the 2.0.0 release, so there's no need to rebase now.

Ah, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants