Add input check to mp_pack and mp_pack_count#602
Open
MagicalTux wants to merge 1 commit into
Open
Conversation
When nails == size*8 the (size*8) - nails divisor was zero, causing a division by zero.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mp_pack_countcomputesbits / ((size*8) - nails). Whennails == size*8the divisor is zero — a division by zero (SIGFPE on x86).mp_packcallsmp_pack_countunconditionally, so the same crash is reachable throughmp_pack.Like
mp_unpack, these parameters can originate from an external format, making the bad combination reachable from untrusted input.Fix: reject
size == 0andnails >= size*8early in both functions (mp_pack_countreturns 0,mp_packreturnsMP_VAL). The check is placed beforemp_count_bitsinmp_pack_count.Confirmed with UndefinedBehaviorSanitizer:
Reproducer:
mp_pack_count(&a, 8, 1);