Assume game is active until lichess says otherwise (#1164)

Previously, if a communication error prevented lichess from sending
ongoing games, an empty list would be returned from the Lichess
function. This could cause game_is_active() to return False during a
temporary communication error during a game. This would cause a game to
be aborted locally even if the game is actually ongoing.

Now, when checking if a game is ongoing, don't assume a game is over
until a list is successfully received from lichess.

Author: MarkZH

lib/lichess.py

@@ -401,13 +401,16 @@ def get_profile(self) -> UserProfileType:
         self.set_user_agent(profile["username"])
         return profile
 
-    def get_ongoing_games(self) -> list[GameType]:
-        """Get the bot's ongoing games."""
-        ongoing_games: list[GameType] = []
+    def get_ongoing_games(self) -> list[GameType] | None:
+        """
+        Get the bot's ongoing games.
+
+        If an error occurs when retreiving the games, None is returned.
+        """
         with contextlib.suppress(Exception):
             response = cast(dict[str, list[GameType]], self.api_get_json("playing"))
-            ongoing_games = response["nowPlaying"]
-        return ongoing_games
+            return response["nowPlaying"]
+        return None
 
     def resign(self, game_id: str) -> None:
         """Resign a game."""

lib/lichess_bot.py

@@ -343,7 +343,7 @@ def lichess_bot_main(li: lichess.Lichess,
 
     one_game_completed = False
 
-    all_games = li.get_ongoing_games()
+    all_games = li.get_ongoing_games() or []
     prune_takeback_records(all_games)
     startup_correspondence_games = [game["gameId"]
                                     for game in all_games
@@ -540,7 +540,10 @@ def sort_challenges(challenge_queue: MULTIPROCESSING_LIST_TYPE, challenge_config
 
 def game_is_active(li: lichess.Lichess, game_id: str) -> bool:
     """Determine if a game is still being played."""
-    return game_id in (ongoing_game["gameId"] for ongoing_game in li.get_ongoing_games())
+    active_games = li.get_ongoing_games()
+    if active_games is None:
+        return True
+    return game_id in (ongoing_game["gameId"] for ongoing_game in active_games)
 
 
 def start_game_thread(active_games: set[str], game_id: str, play_game_args: PlayGameArgsType, pool: POOL_TYPE) -> None:
@@ -613,7 +616,8 @@ def handle_challenge(event: EventType, li: lichess.Lichess, challenge_queue: MUL
     if chlng.from_self:
         return
 
-    opponent_engagements = Counter(game["opponent"]["username"] for game in li.get_ongoing_games())
+    active_games = li.get_ongoing_games() or []
+    opponent_engagements = Counter(game["opponent"]["username"] for game in active_games)
     opponent_engagements.update(challenge.challenger.name for challenge in challenge_queue)
 
     online_block_list.refresh()