Handle failed token test without leaking token#1138
Merged
AttackingOrDefending merged 1 commit intoOct 1, 2025
Merged
Conversation
If the line `token_info = token_response[token]` fails with a `KeyError` (due to an error response from lichess), the user's token will be printed in the error message. Use `token_response.get()` to prevent this. Also, use `.get()` on the resulting `token_info` to print a more useful error message.
AttackingOrDefending
approved these changes
Oct 1, 2025
AttackingOrDefending
merged commit c5bbdea
into
lichess-bot-devs:master
23 checks passed
r0950336
pushed a commit
to r0950336/lichess-bot
that referenced
this pull request
Dec 31, 2025
If the line `token_info = token_response[token]` fails with a `KeyError` (due to an error response from lichess), the user's token will be printed in the error message. Use `token_response.get()` to prevent this. Also, use `.get()` on the resulting `token_info` to print a more useful error message.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of pull request:
Description:
If the line
token_info = token_response[token]fails with aKeyError(due to an error response from lichess), the user's token will be printed in the error message. Usetoken_response.get()to prevent this.Related Issues:
Checklist:
Screenshots/logs (if applicable):