Allow "engine debugging" to be enabled.#1152
Conversation
|
Good idea. Just fix the errors in the tests. Namely, the |
|
@MarkZH hi, I made the change. Could not find any other class that Stockfish inherits from. But pytest with the latest fix runs fine and it hangs without the fix so my guess is that it is now good? |
| engine: # Engine settings. | ||
| dir: "./engines/" # Directory containing the engine. This can be an absolute path or one relative to lichess-bot/. | ||
| name: "engine_name" # Binary name of the engine to use. | ||
| debug: False # Should all commands between Lichess & bot be logged? |
There was a problem hiding this comment.
This isn't really an accurate description. Setting debug: True prints messages about starting and stopping the engine executable. Showing UCI/Xboard communication is controlled by the -v option on the command line.
|
I forgot to mention, please add documentation to the config wiki page: |
Done! |
|
Can you fix the mypy errors? |
Parameter is unused.
Remove unused name parameter (no other code uses it) and replace it with debug so all EngineWrapper classes have same __init__(). Remove default argument values to ensure __init__() is called correctly.
AttackingOrDefending
merged commit 9b145a1
into
lichess-bot-devs:master
3 participants
Type of pull request:
Description:
This change allows a developer to enable UCI/XBoard protocol debugging to be enabled. This helps debugging communication problems between lichess-bot and certain chess engines.
Related Issues:
[Reference any related issues that this pull request addresses or closes. Use the syntax
Closes #issue_numberto automatically close the linked issue upon merging.]Checklist:
Screenshots/logs (if applicable):