Fix signal handler for soft-quitting lichess-bot#1156
Merged
AttackingOrDefending merged 2 commits intoDec 5, 2025
Conversation
Collaborator
Author
|
This needs more testing, but I think this might work. |
Collaborator
Author
|
I think this is ready for review and/or merging. The users in the issue thread #1155 also think so, too. The only side effect I've noticed is the printing of "Received SIGINT. Terminating client" multiple times on the first SIGINT (one for each process). |
AttackingOrDefending
approved these changes
Dec 5, 2025
AttackingOrDefending
merged commit dba17f8
into
lichess-bot-devs:master
17 of 23 checks passed
r0950336
pushed a commit
to r0950336/lichess-bot
that referenced
this pull request
Dec 31, 2025
* Delete condition that is always False * Remove terminated condition from API giveup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of pull request:
Description:
Fixes SIGINT handler so that lichess-bot can be quit while multiple games are playing without stopping other games.
Related Issues:
Closes #1155
Checklist:
Screenshots/logs (if applicable):